Closed Bug 1063696 Opened 10 years ago Closed 10 years ago

Intermittent e10s browser_datareporting_notification.js | Test timed out - expected PASS

Categories

(Firefox Health Report Graveyard :: Client: Desktop, defect)

Product:
Firefox Health Report Graveyard
Component:
Client: Desktop
Platform:
All
Other
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(e10s+, firefox33 unaffected, firefox34 unaffected, firefox35 fixed, firefox-esr31 unaffected)

Status:
RESOLVED FIXED
Milestone:
Firefox 35
Tracking Flags:
Tracking Status
e10s + ---
firefox33 --- unaffected
firefox34 --- unaffected
firefox35 --- fixed
firefox-esr31 --- unaffected

People

(Reporter: RyanVM, Assigned: markh)

References

(Blocks 1 open bug)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

0001-Bug-1063696-fix-datareporting-timeout-orange-by-not-.patch
3.39 KB, patch
gfritzsche
: review+
Details | Diff | Splinter Review
Don't know if this being an e10s run is relevant or not, but worth pointing out I guess. https://tbpl.mozilla.org/php/getParsedLog.php?id=47491640&tree=B2g-Inbound Ubuntu VM 12.04 x64 b2g-inbound opt test mochitest-e10s-browser-chrome-1 on 2014-09-05 10:27:46 PDT for push d3460a515717 slave: tst-linux64-spot-161 10:31:20 INFO - dumping last 37 message(s) 10:31:20 INFO - if you need more context, please use SimpleTest.requestCompleteLog() in your test 10:31:20 INFO - 93 INFO checking window state 10:31:20 INFO - 94 INFO Console message: [JavaScript Error: "content is null" {file: "resource://gre/modules/commonjs/framescript/tab-events.js" line: 40}] 10:31:20 INFO - 95 INFO TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/general/browser_datareporting_notification.js | Health Reporter instance is available. 10:31:20 INFO - 96 INFO TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/general/browser_datareporting_notification.js | Health Reporter prefs are available. 10:31:20 INFO - 97 INFO TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/general/browser_datareporting_notification.js | No version should be set on init. 10:31:20 INFO - 98 INFO TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/general/browser_datareporting_notification.js | No date should be set on init. 10:31:20 INFO - 99 INFO TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/general/browser_datareporting_notification.js | User not notified about datareporting policy. 10:31:20 INFO - 100 INFO Console message: 1409938235236 Services.HealthReport.HealthReporter WARN Saved state file does not exist. 10:31:20 INFO - 101 INFO Console message: 1409938235238 Services.HealthReport.HealthReporter WARN No prefs data found. 10:31:20 INFO - 102 INFO TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/general/browser_datareporting_notification.js | Notification Displayed. 10:31:20 INFO - 103 INFO TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/general/browser_datareporting_notification.js | User not notified about data policy on init. 10:31:20 INFO - 104 INFO TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/general/browser_datareporting_notification.js | _userNotifyPromise defined. 10:31:20 INFO - 105 INFO TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/general/browser_datareporting_notification.js | Policy version set. 10:31:20 INFO - 106 INFO TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/general/browser_datareporting_notification.js | Policy date set. 10:31:20 INFO - 107 INFO TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/general/browser_datareporting_notification.js | User notified about datareporting policy. 10:31:20 INFO - 108 INFO TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/general/browser_datareporting_notification.js | No notifications remain. 10:31:20 INFO - 109 INFO TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/general/browser_datareporting_notification.js | Version pref set. 10:31:20 INFO - 110 INFO TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/general/browser_datareporting_notification.js | Date pref set. 10:31:20 INFO - 111 INFO TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/general/browser_datareporting_notification.js | 2nd window has a global notification box. 10:31:20 INFO - 112 INFO TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/general/browser_datareporting_notification.js | Health Reporter instance is available. 10:31:21 INFO - 113 INFO TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/general/browser_datareporting_notification.js | Health Reporter prefs are available. 10:31:21 INFO - 114 INFO TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/general/browser_datareporting_notification.js | User not notified about data policy on init. 10:31:21 INFO - 115 INFO TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/general/browser_datareporting_notification.js | _userNotifyPromise defined. 10:31:21 INFO - 116 INFO TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/general/browser_datareporting_notification.js | Data reporting info bar displayed on all open windows. 10:31:21 INFO - 117 INFO TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/general/browser_datareporting_notification.js | There is 1 button in the data reporting notification. 10:31:21 INFO - 118 INFO Console message: [JavaScript Error: "content is null" {file: "resource://gre/modules/commonjs/framescript/tab-events.js" line: 40}] 10:31:21 INFO - 119 INFO Console message: [JavaScript Error: "content is null" {file: "resource://gre/modules/commonjs/framescript/tab-events.js" line: 40}] 10:31:21 INFO - 120 INFO TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/general/browser_datareporting_notification.js | Advanced preferences opened on info bar button press. 10:31:21 INFO - 121 INFO Console message: [JavaScript Error: "content is null" {file: "resource://gre/modules/commonjs/framescript/tab-events.js" line: 40}] 10:31:21 INFO - 122 INFO Console message: [JavaScript Error: "content is null" {file: "resource://gre/modules/commonjs/framescript/tab-events.js" line: 40}] 10:31:21 INFO - 123 INFO Console message: [JavaScript Error: "content is null" {file: "resource://gre/modules/commonjs/framescript/tab-events.js" line: 40}] 10:31:21 INFO - 124 INFO TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/general/browser_datareporting_notification.js | Closing info bar on one window closed them on all. 10:31:21 INFO - 125 INFO TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/general/browser_datareporting_notification.js | Data submission policy accepted. 10:31:21 INFO - 126 INFO TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/general/browser_datareporting_notification.js | No notifications remain on main window. 10:31:21 INFO - 127 INFO Console message: [JavaScript Error: "notification2.allNotifications is undefined" {file: "chrome://mochitests/content/browser/browser/base/content/test/general/browser_datareporting_notification.js" line: 181}] 10:31:21 INFO - 128 INFO Console message: [JavaScript Error: "prefStrBundle.getFormattedString is not a function" {file: "chrome://browser/content/preferences/in-content/advanced.js" line: 318}] 10:31:21 INFO - 129 INFO TEST-FAIL | chrome://mochitests/content/browser/browser/base/content/test/general/browser_datareporting_notification.js | A promise chain failed to handle a rejection 10:31:21 INFO - 130 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/general/browser_datareporting_notification.js | Test timed out - expected PASS 10:31:21 INFO - 131 INFO TEST-OK | chrome://mochitests/content/browser/browser/base/content/test/general/browser_datareporting_notification.js | took 45063ms
https://tbpl.mozilla.org/php/getParsedLog.php?id=47496505&tree=Mozilla-Inbound Guess that answers that.
Component: General → Client: Desktop
Product: Firefox → Firefox Health Report
Summary: Intermittent browser_datareporting_notification.js | Test timed out - expected PASS → Intermittent e10s browser_datareporting_notification.js | Test timed out - expected PASS
Assignee: nobody → mhammond
The problem here is (as usual for oranges), timing. In tests that fail, the test closes the second window *before* it has examined that window's notification2.allNotifications object. In this case it is null and the test times out. The test also appears to be a little confused about window closing - it closes the only tab (about:preferences) in the window - which closes the window - *and* explicitly calls window.close. It's this first close of the tab that is ultimately responsible for the timing issue. The fix is to simply note the preference window opened, but don't attempt to close it, and just close the window as normal at the end of the test. Try at https://tbpl.mozilla.org/?tree=Try&rev=88f957b1def0, which also includes the patch to bug 1064137. Requesting review from Georg as the most recent significant modifier if this test.
Attachment #8489194 - Flags: review?(georg.fritzsche)
Comment on attachment 8489194 [details] [diff] [review] 0001-Bug-1063696-fix-datareporting-timeout-orange-by-not-.patch Review of attachment 8489194 [details] [diff] [review]: ----------------------------------------------------------------- This looks better, thanks.
Attachment #8489194 - Flags: review?(georg.fritzsche) → review+
https://hg.mozilla.org/integration/fx-team/rev/5c47fd7e9b4a
Status: NEW → ASSIGNED
OS: Windows 8.1 → Other
Hardware: x86 → All
Flags: qe-verify-
Flags: firefox-backlog+
Hi Mark, can you provide a point value.
Iteration: --- → 35.2
Flags: needinfo?(mhammond)
Points: --- → 3
Flags: needinfo?(mhammond)
Iteration: 35.2 → 35.1
https://hg.mozilla.org/mozilla-central/rev/5c47fd7e9b4a
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
Depends on: 1073855
Product: Firefox Health Report → Firefox Health Report Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: