Closed
Bug 1063698
Opened 10 years ago
Closed 10 years ago
Add action to UITour.jsm for opening the Reset Firefox dialog
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
People
(Reporter: adw, Assigned: alexbardas)
References
Details
(Whiteboard: [fxgrowth])
Attachments
(1 file)
|
4.67 KB,
patch
|
Unfocused
:
review+
|
Details | Diff | Splinter Review |
Broken down from bug 1062345.
Gavin said to use UITour.jsm for this like bug 998934 did for Firefox accounts, which seems weird to me, but OK. :-)
|
||
Updated•10 years ago
|
Flags: qe-verify?
Flags: firefox-backlog+
|
Reporter | |
Updated•10 years ago
|
Points: --- → 3
|
|
Reporter | |
Updated•10 years ago
|
Flags: qe-verify? → qe-verify-
|
|
||
Updated•10 years ago
|
Assignee: nobody → abardas
Status: NEW → ASSIGNED
Iteration: --- → 35.2
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8491083 -
Flags: review?(bmcbride)
|
||
Comment 2•10 years ago
|
||
(In reply to Drew Willcoxon :adw from comment #0)
> Gavin said to use UITour.jsm for this like bug 998934 did for Firefox
> accounts, which seems weird to me, but OK. :-)
I had suggested we put this in the Firefox self-repair functionality being worked on (which will also be able to be triggered by content AFAICT). If that's not ready then I guess it's okay for UITour for now.
|
||
Comment 3•10 years ago
|
||
(In reply to Matthew N. [:MattN] from comment #2)
> I had suggested we put this in the Firefox self-repair functionality being
> worked on (which will also be able to be triggered by content AFAICT). If
> that's not ready then I guess it's okay for UITour for now.
I'm not aware of any code having been written yet, let alone it being near ready.
|
|
||
Comment 4•10 years ago
|
||
Comment on attachment 8491083 [details] [diff] [review]
[Patch] Add action to UITour.jsm for opening the Reset Firefox dialog
Review of attachment 8491083 [details] [diff] [review]:
-----------------------------------------------------------------
Send a pull request to https://github.com/Unfocused/mozilla-uitour/ to get the JS library updated there.
Attachment #8491083 -
Flags: review?(bmcbride) → review+
|
|
Assignee | |
Comment 5•10 years ago
|
||
|
|
Assignee | |
Comment 6•10 years ago
|
||
The try doesn't look great, but there are no errors related to this.
Keywords: checkin-needed
|
||
Comment 7•10 years ago
|
||
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
|
|
||
Comment 8•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 35
|
||
Updated•10 years ago
|
Whiteboard: [fxgrowth]
You need to log in
before you can comment on or make changes to this bug.
Description
•