Closed Bug 1063753 Opened 5 years ago Closed 5 years ago

Remove Remote Tabs tray from Fennec entirely

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 36

People

(Reporter: nalexander, Assigned: nalexander)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 3 obsolete files)

Bug 1014994 landed a Remote Tabs home panel.  Bug 1063750 tracks messaging users gently that their synced tabs tray has moved to be a home panel.

This ticket tracks removing the code and assets for the synced tabs tray from the tree entirely.  This should ride the train after Bug 1063750 lands.
Huh, I can't make this tracking-firefox36.  I've marked its dependent ticket tracking-firefox35; this should ride one train later.
mhaigh is doing some work in larch that might conflict with this a bit. mhaigh, please keep an eye on these changes.
Flags: needinfo?(mhaigh)
Don't think this'll change anything I'm doing, but will keep an eye on it.
Flags: needinfo?(mhaigh)
This should land right at the end of the Fennec 36 cycle, since we may be uplifting code changes to Aurora.
Blocks: remotetabsv2
This mops up the bits of the Remote Tabs tray not already deleted by Bug
1014994.

Tested locally on a phone; charging my tablet.
Attachment #8517206 - Flags: review?(michael.l.comella)
This mops up the bits of the Remote Tabs tray not already deleted by Bug
1014994.

mcomella: sorry, missed a spot.  Having trouble with IntelliJ and
files linked in multiple places.
Attachment #8517206 - Attachment is obsolete: true
Attachment #8517206 - Flags: review?(michael.l.comella)
Attachment #8517213 - Flags: review?(michael.l.comella)
This mops up the bits of the Remote Tabs tray not already deleted by Bug
1014994.

And a little more.  Sorry!
Attachment #8517213 - Attachment is obsolete: true
Attachment #8517213 - Flags: review?(michael.l.comella)
Attachment #8517240 - Flags: review?(michael.l.comella)
Assignee: nobody → nalexander
Status: NEW → ASSIGNED
Comment on attachment 8517240 [details] [diff] [review]
Remove Remote Tabs tray from Fennec entirely.

Review of attachment 8517240 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm provided a green try run.

::: mobile/android/base/tabs/TabsPanel.java
@@ +194,5 @@
>      @Override
>      public void onTabChanged(int index) {
>          if (index == 0) {
>              show(Panel.NORMAL_TABS);
>          } else if (index == 1) {

Maybe add an `else { throw... }` clause?
Attachment #8517240 - Flags: review?(michael.l.comella) → review+
> ::: mobile/android/base/tabs/TabsPanel.java
> @@ +194,5 @@
> >      @Override
> >      public void onTabChanged(int index) {
> >          if (index == 0) {
> >              show(Panel.NORMAL_TABS);
> >          } else if (index == 1) {
> 
> Maybe add an `else { throw... }` clause?

This is reasonable, but I instead took the old pattern of defaulting to the last entry (in this case, PRIVATE_TABS).
This mops up the bits of the Remote Tabs tray not already deleted by Bug
1014994.

This incorporates mcomella's feedback.  The tree is closed so marking
checkin-needed and carrying over the r+.
Attachment #8517240 - Attachment is obsolete: true
Hi Nick, 

seems this patch didn't apply cleanly:

applying Bug-1063753---Remove-Remote-Tabs-tray-from-Fennec-.patch
patching file mobile/android/base/moz.build
Hunk #1 FAILED at 386
1 out of 1 hunks FAILED -- saving rejects to file mobile/android/base/moz.build.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working dir
errors during apply, please fix and refresh Bug-1063753---Remove-Remote-Tabs-tray-from-Fennec-.patch

could you take a look, thanks!
Flags: needinfo?(nalexander)
Flags: needinfo?(nalexander)
https://hg.mozilla.org/mozilla-central/rev/597441df1450
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 36
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.