1063889 - Web IDL codegen messes up union members that are sequences of a wrapper type

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

This happens because we use str() in both getUnionMemberName and the typeName() method in IDLUnionType.complete, but for a sequence of wrappers that ends up with something like "Node (Wrapper)Sequence".  Which is not helpful.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix the handling of sequences of wrapper types in unions

I wish we had some sort of principled thing here... .name seems closest.  __str__ is certainly not it.

Comment 2

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2f5df573f4a3

Fabrice, let me know if we need this on branches, ok?

Comment 3

[Boris Zbarsky [:bzbarsky]]

And backed out because windowsx.h exists.

Will reland after a try run on Windows debug.

Comment 4

[[:fabrice] Fabrice Desré]

(In reply to Boris Zbarsky [:bz] from comment #2)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/2f5df573f4a3
> 
> Fabrice, let me know if we need this on branches, ok?

We don't! thanks for the quick fix!

Comment 5

[Boris Zbarsky [:bzbarsky]]

Let's try this again: https://hg.mozilla.org/integration/mozilla-inbound/rev/f0fbb5c6c672

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f0fbb5c6c672