Closed Bug 1063889 Opened 7 years ago Closed 7 years ago
Web IDL codegen messes up union members that are sequences of a wrapper type
This happens because we use str() in both getUnionMemberName and the typeName() method in IDLUnionType.complete, but for a sequence of wrappers that ends up with something like "Node (Wrapper)Sequence". Which is not helpful.
I wish we had some sort of principled thing here... .name seems closest. __str__ is certainly not it.
Attachment #8485367 - Flags: review?(khuey)
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Attachment #8485367 - Flags: review?(khuey) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/2f5df573f4a3 Fabrice, let me know if we need this on branches, ok?
Target Milestone: --- → mozilla35
And backed out because windowsx.h exists. Will reland after a try run on Windows debug.
(In reply to Boris Zbarsky [:bz] from comment #2) > https://hg.mozilla.org/integration/mozilla-inbound/rev/2f5df573f4a3 > > Fabrice, let me know if we need this on branches, ok? We don't! thanks for the quick fix!
Let's try this again: https://hg.mozilla.org/integration/mozilla-inbound/rev/f0fbb5c6c672
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.