1064083 - Import (and pass) img/picture web platform tests

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[John Schoenick [:johns]]

https://github.com/w3c/web-platform-tests/pull/1234

As we land picture and update <img>, we should pull in the web platform tests where possible (and pass them).

Comment 1

[Mike Taylor [:miketaylr]]

It looks like we've already imported these tests but have most of them disabled: https://dxr.mozilla.org/mozilla-central/source/testing/web-platform/meta/html/semantics/embedded-content/the-img-element

I'd be happy to help get the ones that we do pass enabled, and ideally file bugs on the rest (if they don't already exist).

John, do you mind if I help out here?

Comment 2

[John Schoenick [:johns]]

(In reply to Mike Taylor [:miketaylr] from comment #1)
> It looks like we've already imported these tests but have most of them
> disabled:
> https://dxr.mozilla.org/mozilla-central/source/testing/web-platform/meta/
> html/semantics/embedded-content/the-img-element
> 
> I'd be happy to help get the ones that we do pass enabled, and ideally file
> bugs on the rest (if they don't already exist).
> 
> John, do you mind if I help out here?

Sure - we have bug 1139554 and bug 1139560 about some of these failures, it would be super helpful to go through the remaining ones and make sure they have bugs blocking this one.

I can help work on some of these as they come up, but have someone limited time recently

Comment 3

[Mike Taylor [:miketaylr]]

Cool, thanks. I'll have some time for this early next week.

Comment 4

[Mike Taylor [:miketaylr]]

I added a patch updating expectations for Bug 1139560. Once that lands, I'll update the expectations related to Bug 1139554 (I think I'll just get conflicts if I try before 1139560 lands) and then file bugs on the rest of the failures.

Comment 5

[Josh Matthews [:jdm]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=71d2e883cfb8

Comment 6

[Mike Taylor [:miketaylr]]

Yeah, this is a little messy--I wasn't sure what order all these related patches would land. It looks like bug 1139554 will land first, which means the WPT updates patch in 1139560 will be bit-rotted (but it's an easy rebase). So I'll upload a patch to 1139554 and update a rebased patch to 1139560, assuming they land in that order.

Does that make sense, Josh?

Comment 7

[Josh Matthews [:jdm]]

It does. Thanks!

Comment 8

[Josh Matthews [:jdm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8dc24100ee36

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Backed out for w-p-t failures.
https://hg.mozilla.org/integration/mozilla-inbound/rev/dcc49f2ed016

https://treeherder.mozilla.org/logviewer.html#?job_id=8158212&repo=mozilla-inbound

Comment 10

[Mike Taylor [:miketaylr]]

Huh, I guess the srcset fixes broke that test. Odd that it didn't fail on my machine. The quick fix is to disable that test and file a bug for investigation. Filing now.

Comment 11

[Mike Taylor [:miketaylr]]

Actually I'll just point to this bug, the point of this bug is to figure out the rest of the failures and file meaningful bugs for them. We're not quite in meaningful territory yet.

Comment 12

[Mike Taylor [:miketaylr]]

Note to self: 

 0:11.93 TEST_END: Thread-TestrunnerManager-1 Harness OK. Subtests passed 80/89. Unexpected 1
<img src="data:,a" srcset="data:,b 10000x, data:,c 10000w" sizes="1px" data-expect="data:,b">
---------------------------------------------------------------------------------------------
Expected FAIL, got PASS

vs

12:46:38 INFO - TEST-UNEXPECTED-FAIL | /html/semantics/embedded-content/the-img-element/update-the-source-set.html | <img src="data:,a" srcset="data:,b 10000x, data:,c 10000w" sizes="1px" data-expect="data:,b"> - assert_equals: expected "data:,b" but got "data:,a"

The updated patch in Bug 1139560 disables this test and points back here. Once all the moving parts land, will investigate further.

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bb871246ca63

Comment 15

[Josh Matthews [:jdm]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=38dfe3e0a7ff

Comment 16

[Josh Matthews [:jdm]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e649494dd293

Comment 17

[Josh Matthews [:jdm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b8c0cfa633b4

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b8c0cfa633b4

Comment 19

[Josh Matthews [:jdm]]

Attachment: Update srcset web-platform expectations