Closed Bug 1064363 Opened 5 years ago Closed 5 years ago

Remove unused WebSocket library

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 35

People

(Reporter: mfinkle, Assigned: rnewman)

References

(Blocks 1 open bug)

Details

Attachments

(3 files, 1 obsolete file)

Bug 834033 landed a WebSocket library to support SimplePush. Snorp says this is never going to be used for Push support, so let's remove it. Of the four cset's landed in bug 834033:

https://hg.mozilla.org/mozilla-central/rev/0bf3505c02b2
https://hg.mozilla.org/mozilla-central/rev/05a6210472f1
https://hg.mozilla.org/mozilla-central/rev/c1779b8d2bf1
https://hg.mozilla.org/mozilla-central/rev/a597da48b937

I think the only one we need to back out for WebSockets is:
https://hg.mozilla.org/mozilla-central/rev/c1779b8d2bf1

This cset does package more in our APK, but I don't know if we want the SystemMessage stuff or not. Maybe just remove the Push.js stuff, but DO NOT remove the necko_websocket.xpt stuff:
https://hg.mozilla.org/mozilla-central/rev/05a6210472f1
Blocks: fatfennec
OS: Linux → Android
Hardware: x86_64 → All
I will probably end up doing this.
Assignee: nobody → rnewman
Status: NEW → ASSIGNED
Depends on: 834033
Assuming that this isn't used by anything else. It's a DOM API, and I don't think we care.
Attachment #8486492 - Flags: review?(snorp)
Same. I took a look at this code, and it doesn't seem at all relevant to Fennec.
Attachment #8486494 - Flags: review?(snorp)
Because why specify dependencies in one place when two will do?
Attachment #8486525 - Flags: review?(snorp)
Attachment #8486491 - Attachment is obsolete: true
Attachment #8486491 - Flags: review?(snorp)
Try is happy.
Comment on attachment 8486492 [details] [diff] [review]
Part 2: remove Push.js. v1

Review of attachment 8486492 [details] [diff] [review]:
-----------------------------------------------------------------

We'll need this (or something similar) eventually, I think. Can take it out for now.
Attachment #8486492 - Flags: review?(snorp) → review+
Comment on attachment 8486494 [details] [diff] [review]
Part 3: remove SystemMessage stuff. v1

Review of attachment 8486494 [details] [diff] [review]:
-----------------------------------------------------------------

I don't even know what this is, but looks B2G related?
Attachment #8486494 - Flags: review?(snorp) → review+
Attachment #8486525 - Flags: review?(snorp) → review+
You need to log in before you can comment on or make changes to this bug.