1064363 - Remove unused WebSocket library

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Bug 834033 landed a WebSocket library to support SimplePush. Snorp says this is never going to be used for Push support, so let's remove it. Of the four cset's landed in bug 834033:

https://hg.mozilla.org/mozilla-central/rev/0bf3505c02b2
https://hg.mozilla.org/mozilla-central/rev/05a6210472f1
https://hg.mozilla.org/mozilla-central/rev/c1779b8d2bf1
https://hg.mozilla.org/mozilla-central/rev/a597da48b937

I think the only one we need to back out for WebSockets is:
https://hg.mozilla.org/mozilla-central/rev/c1779b8d2bf1

This cset does package more in our APK, but I don't know if we want the SystemMessage stuff or not. Maybe just remove the Push.js stuff, but DO NOT remove the necko_websocket.xpt stuff:
https://hg.mozilla.org/mozilla-central/rev/05a6210472f1

Comment 1

[Richard Newman [:rnewman]]

I will probably end up doing this.

Comment 2

[Richard Newman [:rnewman]]

Attachment: Part 1: remove third-party WebSocket library. v1

Per Bug 834033 Comment 75.

Comment 3

[Richard Newman [:rnewman]]

Attachment: Part 2: remove Push.js. v1

Assuming that this isn't used by anything else. It's a DOM API, and I don't think we care.

Comment 4

[Richard Newman [:rnewman]]

Attachment: Part 3: remove SystemMessage stuff. v1

Same. I took a look at this code, and it doesn't seem at all relevant to Fennec.

Comment 5

[Richard Newman [:rnewman]]

https://tbpl.mozilla.org/?tree=Try&rev=a453f64e6362

Comment 6

[Richard Newman [:rnewman]]

Attachment: Part 1: remove third-party WebSocket library. v2

Because why specify dependencies in one place when two will do?

Comment 7

[Richard Newman [:rnewman]]

https://tbpl.mozilla.org/?tree=Try&rev=26432e129814

Comment 8

[Richard Newman [:rnewman]]

Try is happy.

Comment 9

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8486492 [details] [diff] [review]
Part 2: remove Push.js. v1

Review of attachment 8486492 [details] [diff] [review]:
-----------------------------------------------------------------

We'll need this (or something similar) eventually, I think. Can take it out for now.

Comment 10

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8486494 [details] [diff] [review]
Part 3: remove SystemMessage stuff. v1

Review of attachment 8486494 [details] [diff] [review]:
-----------------------------------------------------------------

I don't even know what this is, but looks B2G related?

Comment 11

[Richard Newman [:rnewman]]

https://hg.mozilla.org/integration/fx-team/rev/cbcf1d354938
https://hg.mozilla.org/integration/fx-team/rev/2c4ae93e8784
https://hg.mozilla.org/integration/fx-team/rev/341ae3a743a5

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/cbcf1d354938
https://hg.mozilla.org/mozilla-central/rev/2c4ae93e8784
https://hg.mozilla.org/mozilla-central/rev/341ae3a743a5