1064463 - GET/SET CLIR (calling line identity restriction) calls on boot up causing GCF failures

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Anshul]

On Firefox OS the get/set CLIR APIs are called every time on bootup. This is interfering with GCF conformance testing, which is not very sympathetic toward any unexpected NW related requests. Because of this, any SS/USSD/SMS related tests are being given a fail verdict.

[Blocking Requested - why for this release]: This issue is blocking couple of GCF certification test cases.

Comment 1

[Anshul]

The GCF tests pass on Android and on further analysis I found that Android doesn't set/get the CLIR setting after loading a new build as the default setting is -1. Once a user goes to the settings UI the call to get CLIR is made as expected. Once the CLIR setting is updated in the database, Android as well get/set CLIR on reboots there after.

So the only difference is the very first time after a fresh build load, which is when the GCF tests are run.

Comment 2

[howie [:howie]]

Triage: blocking as certification test case

Comment 3

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: link to https://github.com/mozilla-b2g/gaia/pull/24417

Alive, could you help review this simple patch? The intention is to avoid setting caller id when there is no user preference (that is also the same time when the GCF certification test is performed). Once users set their preference in settings, the behavior is as usual.

Anshul, please help check if the patch works, thanks!

Comment 4

[Anshul]

Arthur, I see different behavior between 2.0 and 2.1 w.r.t. CLIR setting with and without your change. Please find the details below.

FFOS 2.0
- After a new build load, Set and Get CLIR are called on boot up with the default value of 0
- If I change the setting to say 2, then Set and Get CLIR are called on bootup with the new value of 2.

FFOS 2.1 (without your change)
- After a new build load, only Get CLIR is being called
- Once the phone is up, when I go to the settings app, I see Get CLIR being called twice instead of one time.
- I change the CLIR to say 2(show number) and reboot. I only see Get CLIR being called.

FFOS 2.1 (with your change)
- I see the exact same behavior on 2.1 as without your change.

So it seems like there is a regression in 2.1 in that set CLIR is not being called on bootup anymore and so I am unable to verify if your change is fixing the issue.

Comment 5

[Anshul]

Filed bug 1074499 for the issue with set CLIR not working.

Comment 6

[Anshul]

Comment on attachment 8495074 [details]
link to https://github.com/mozilla-b2g/gaia/pull/24417

With the bug 1028544 reverted, I am able to test this patch and find it working as expected.

Comment 7

[Arthur Chen [:arthurcc][inactive after 6/30]]

master: b945f8885b189f0dcea8ef510bc58337b68f72c2

I'll check if the patch for bug 1028544 is valid.

Comment 8

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8495074 [details]
link to https://github.com/mozilla-b2g/gaia/pull/24417

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): N/A
[User impact] if declined: This is a certification blocker
[Testing completed]: Manual tests were completed. Unit tests were added.
[Risk to taking this patch] (and alternatives if risky): Low
[String changes made]: N/A

Comment 9

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/9d588ec5f09096c113913f2db2c216e2caf89ff1

Comment 10

[Alissa（leave from Mozilla）]

Hi,Anshul 
Could you provid the step details for me?
thanks.

Comment 11

[Anshul]

Alissa, the steps are pretty basic. Reboot the phone and make sure no CLIR calls are sent to RIL.

Comment 12

[Mike Lien[:mlien]]

Hi Arthur, could you help to describe how to make sure if CLIR calls are sent to RIL? If any log or information Alissa can follow to verify this issue?

Comment 13

[Arthur Chen [:arthurcc][inactive after 6/30]]

Hsinyi, is there any log from gecko providing such information?

Comment 14

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Hi,
You could grep the string "setCLIR" or "getCLIR". If you see them, that means gecko receives the commands.

Comment 15

[Alissa（leave from Mozilla）]

This issue has been verified successfully on  2.1, 2.2.
Reproducing rate: 0/5
Flame 2.1 build:
Gaia-Rev        77c57eb8a985d5cbd34a597fb1b978ba6e205af6
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/4c28bb3be0c6
Build-ID        20150121001510
Version         34.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150121.034530
FW-Date         Wed Jan 21 03:45:41 EST 2015
Bootloader      L1TC000118D0
Flame 2.2 
Gaia-Rev        e4f9b5da3751798f9cc5d95f302c30722cc11fca
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/75a462a58d7a
Build-ID        20150121002607
Version         37.0a2
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150121.040751
FW-Date         Wed Jan 21 04:08:02 EST 2015
Bootloader      L1TC000118D0