Closed Bug 1064593 Opened 10 years ago Closed 10 years ago

Pass the activity name used in the loop client app as a string in order to make it easier to automatically extract the activity name from the source code

Categories

(Firefox OS Graveyard :: Gaia::Loop, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
2.1 S4 (12sep)

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

References

Details

Attachments

(1 file)

46 bytes, text/x-github-pull-request
arcturus
: review+
ferjm
: feedback+
Details | Review
+++ This bug was initially created as a clone of Bug #1062564 +++ I'm working on a static analysis tool which can extract information about all MozActivity API usages from the gaia source code. It's much simper for this tool if the activity name argument was passed as a script. I have a simple patch which does this for the loop app.
Summary: Pass the activity name used in the loop client app as a string in order to make it easier to automatically extract the activity arguments from the source code → Pass the activity name used in the loop client app as a string in order to make it easier to automatically extract the activity name from the source code
Attached file Patch (v1)
Attachment #8486083 - Flags: review?(ferjmoreno)
Comment on attachment 8486083 [details] [review] Patch (v1) Thanks Ehsan. The change looks good to me, but we need a Contacts app peer to rubberstamp it.
Attachment #8486083 - Flags: review?(francisco)
Attachment #8486083 - Flags: review?(ferjmoreno)
Attachment #8486083 - Flags: feedback+
Comment on attachment 8486083 [details] [review] Patch (v1) LGTM, thanks!
Attachment #8486083 - Flags: review?(francisco) → review+
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S4 (12sep)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: