1064640 - [RTL] Email input fields should be RTL.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[Stephany Wilkes]

Most email input fields have LTR input when language is set to Arabic.

Expected: Input fields should be RTL.

Comment 1

[Stephany Wilkes]

To clarify, this specifically applies to email message fields like subject and message body. There will be exceptions to this general pattern, like password and email address.

Comment 2

[Rabbi Hossain]

Anyone working on it? I think I can fix it. :)

Comment 3

[James Burke [:jrburke]]

No one is actively working on it. I put you as the "assigned" value to indicate it is assigned, but we can change it if you prefer to not be officially assigned.

Comment 4

[Rabbi Hossain]

Thanks for assigning this to me. I have started working on it. Will notify you guys soon about the progress.

Comment 5

[Stephany Wilkes]

Thank you, Rabbi! This issue still reproduces on my latest build, so it's definitely needed. :) Many thanks!

Comment 6

[Stephany Wilkes]

Oh - also a note that we'll need to test this with a working Arabic keyboard, as well. Just a note to myself and/or QA.

Comment 7

[Stephany Wilkes]

Attachment: Email input direction varies between fields.

Adding another screenshot of this issue. On this screen, the top input box is LTR, while the one below is RTL. Text input should be consistent.

Comment 8

[Rabbi Hossain]

Thanks Stephany for your screenshot. I already noticed it. Let me finish the Patch. I will definitely give a PR in next 3 or 4 days. Currently busy on some personal works.

Comment 9

[Stephany Wilkes]

That's fine, Rabbi - no rush. Thank you so much for your help.

Comment 10

[Rabbi Hossain]

sorry for being late. I was quite busy these days. I have completed the patch to fix this issue. Hope I'll be able to push it tomorrow or in 2 days.

Comment 11

[James Burke [:jrburke]]

Bug 1064617 comment 11 makes sure that all inputs have dir="auto" on them, so I expect this will work correctly if the user uses an Arabic keyboard. If using an English, LTR language keyboard, then I expect the platform to align the starting cursor to the left given the language, but start on the right for an RTL language keyboard. 

However I have not been able to confirm directly since an Arabic keyboard is not available by default in a Flame flash. Happy to dive in more if there are pointers to an arabic keyboard to try. Marketplace does not seem to have one.

Comment 12

[Rabbi Hossain]

:jrburke, Does your comment 11 means that the bug is fixed? I was working on it and wrote a possible fix by modifying the CSS but after flashing the latest build I am unable to debug the system apps on my phone. If Bug 1064617 comment 11 fixes the bug, I will unassign it from myself.

Comment 13

[James Burke [:jrburke]]

Rabbi: I believe it is fixed, but to be sure, I would like to try with an RTL keyboard. 

I am not sure how to get one of those on the device yet though, so I did not want to say "fixed" until we got agreement that it was fixed and that dir="auto" and keyboard pairing is the general approach for these input fixes instead of using CSS to do a blanket input change to force a right alignment.

I think it is reasonable that you could unassign yourself for it until that happens. If you know of an RTL keyboard that we can use to verify, it would be great to know more information.

Comment 15

[Ahmed Nefzaoui [:Nefzaoui]]

(In reply to James Burke [:jrburke] from comment #13)
> Rabbi: I believe it is fixed, but to be sure, I would like to try with an
> RTL keyboard. 
> 
> I am not sure how to get one of those on the device yet though, so I did not
> want to say "fixed" until we got agreement that it was fixed and that
> dir="auto" and keyboard pairing is the general approach for these input
> fixes instead of using CSS to do a blanket input change to force a right
> alignment.
> 
> I think it is reasonable that you could unassign yourself for it until that
> happens. If you know of an RTL keyboard that we can use to verify, it would
> be great to know more information.

Having a RTL keyboard requires passing a GAIA_KEYBOARD_LAYOUTS with a parameter en,ar where ar is the Arabic keyboard layout.
And yes, when the input content is not RTL, the text alignment is left to right, when the text is RTL, the text direction is right to left, which is what we exactly need.

Comment 16

[Ahmed Nefzaoui [:Nefzaoui]]

> Having a RTL keyboard requires passing a GAIA_KEYBOARD_LAYOUTS with a
> parameter en,ar where ar is the Arabic keyboard layout.
During building I mean, when doing a make.

e.g. This is my the exact command I pass for Flame when building Gaia and intending to test or work on RTL

make install-gaia PRODUCTION=1 DEVICE_DEBUG=1 REMOTE_DEBUGGER=1 GAIA_DEV_PIXELS_PER_PX=1.5 MOZILLA_OFFICIAL=1 GAIA_KEYBOARD_LAYOUTS=en,fr,ar

Comment 17

[James Burke [:jrburke]]

Based on comment 15, marking this fixed by the change in Bug 1064617 comment 11. Thanks :Nefzaoui for confirming and for showing how to configure the keyboard to show up in an install-gaia!

Comment 18

[Shine(Leave from Mozilla)]

Attachment: screenshot

Hi Rabbi,
This issue still exist on Flame 2.2, On mail account log in view, the Name/Account input fields is not RTL, on new mail compose view, the Subject input field is not RTL.
See attachment: AccountLogIn&NewMailCompose.PNG & logcat_1729.txt
Repro time: 17:29
Reproduce rate 5/5

Flame 2.2 build:
Gaia-Rev        e4f9b5da3751798f9cc5d95f302c30722cc11fca
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/4a90da67661e
Build-ID        20150122002808
Version         37.0a2
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150122.041326
FW-Date         Thu Jan 22 04:13:37 EST 2015
Bootloader      L1TC000118D0

Comment 19

[Shine(Leave from Mozilla)]

Attachment: logcat

Comment 20

[James Burke [:jrburke]]

If you enter Arabic characters with an Arabic keyboard, the text will be right aligned. The text inputs in email all have their dir="auto" attributes set on them, so I believe the alignment of the text is handled by the type of characters that are entered. 

I assumed that alignment should have been driven by the input text, but would be good to get clarification of this: is the current behavior the desired result, or should the text always be right aligned even when entering ltr text?

Will ask swilkes for clarification.

Comment 21

[Stephany Wilkes]

Oh - no. LTR scripts and languages should flow LTR. I filed the bug when I had Arabic selected and saw *it* aligned incorrectly. Thanks James!

Comment 22

[bhavana bajaj [:bajaj]]

Marking it Fixed per last two comments.

Comment 24

[Oliver Nelson [:oliverthor]]

Verifying as fixed in latest 3.0 on flame devices
Followed the command given in comment#16 to produce an Arabic Keyboard (thank you!)

Results: Typing with a RTL-defined language Keyboard (Arabic) results in RTL formatting within E-Mail account setup. Typing with an LTR-defined languaged keyboard (English) results in LTR formatting.

--------------------------------------------------
Environmental Variables:
Device: Flame 3.0
BuildID: 20150205010209
Gaia: 59f71e42d4137f194ca50709497f6e3706dad10a
Gecko: 34a66aaaca81
Gonk: Shallow Flashed after v18D-1 Base
Version: 38.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0
--------------------------------------------------
Device: Flame 2.2
BuildID: 20150205002503
Gaia: 59f71e42d4137f194ca50709497f6e3706dad10a
Gecko: adfba0a07e9b
Gonk: Could not pull gonk.  Did you shallow Flash?
Version: 37.0a2 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
--------------------------------------------------

It is worth noting that while using an RTL keyboard (Arabic), the cursor still begins in an LTR defined position, as noted in bug 1127148, which was duped to this bug.

Comment 25

[Norry.L.F(Leave from Mozilla)]

Test case has been added in moztrap: https://moztrap.mozilla.org/manage/case/15274/

Comment 26

[Sue]

According to comment 24, clear the verifyme tag.