Closed Bug 1064647 Opened 10 years ago Closed 10 years ago

B2G RIL: treat 0x90, 0x91, 0x9E and 0x9F as a success results for sw1 regarding ICC_IO.

Categories

(Firefox OS Graveyard :: RIL, defect)

Product:
Firefox OS Graveyard
Component:
RIL
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:2.0M+, firefox33 wontfix, firefox34 fixed, firefox35 fixed, b2g-v2.0 wontfix, b2g-v2.0M fixed, b2g-v2.1 fixed, b2g-v2.2 fixed)

Status:
RESOLVED FIXED
Milestone:
2.1 S4 (12sep)
Project Flags:
blocking-b2g 2.0M+
Tracking Flags:
Tracking Status
firefox33 --- wontfix
firefox34 --- fixed
firefox35 --- fixed
b2g-v2.0 --- wontfix
b2g-v2.0M --- fixed
b2g-v2.1 --- fixed
b2g-v2.2 --- fixed

People

(Reporter: sku, Assigned: sku)

References

Details

Attachments

(2 files, 2 obsolete files)

Bug 1064647 - B2G RIL: treat 0x90, 0x91, 0x9E and 0x9F as a success results for sw1 regarding ICC_IO. r=Edgar.
1.36 KB, patch
sku
: review+
bajaj
: approval-mozilla-aurora+
Details | Diff | Splinter Review
[2.0m] Bug 1064647 - B2G RIL: treat 0x90, 0x91, 0x9E and 0x9F as a success results for sw1 regarding ICC_IO. r=Edgar.
1.37 KB, patch
sku
: review+
Details | Diff | Splinter Review 
Per 3GPP TS 11.11 clause 9.4.1 Responses to commands which are correctly executed, 0x90, 0x91, 0x9E and 0x9F should all be treated as a success result for sw1 regarding ICC_IO. However, B2G only treats 0x90 (ICC_STATUS_NORMAL_ENDING) as a success result currently.


[1] - http://dxr.mozilla.org/mozilla-central/source/dom/system/gonk/ril_worker.js?from=ril_worker.js&case=true#5857
Assignee: nobody → sku
Attachment #8486148 - Flags: review?(echen)
blocking-b2g: --- → 2.0M?
status-b2g-v2.0M: --- → affected
Comment on attachment 8486148 [details] [diff] [review]
Bug 1064647 - B2G RIL: treat 0x90, 0x91, 0x9E and 0x9F as a success results for sw1 regarding ICC_IO.

Review of attachment 8486148 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you.
Attachment #8486148 - Flags: review?(echen) → review+
Francis, would you like to triage this?
Flags: needinfo?(frlee)
per comment 7, 2.0m+
blocking-b2g: 2.0M? → 2.0M+
Flags: needinfo?(frlee)
Do we need this on v2.1 as well?
Flags: needinfo?(sku)
Hi Ryan:
 Once we need it on v2.1, will request check-in then.

Thanks!!
Shawn
Flags: needinfo?(sku)
https://hg.mozilla.org/mozilla-central/rev/5a69f9fca5ab
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S4 (12sep)
Comment on attachment 8486437 [details] [diff] [review]
Bug 1064647 - B2G RIL: treat 0x90, 0x91, 0x9E and 0x9F as a success results for sw1 regarding ICC_IO. r=Edgar.

Approval Request Comment
[Feature/regressing bug #]: NA
[User impact if declined]: Unable to access some EF on particular SIM card. (i.e. fail to import sim contact, see bug 926053)
[Describe test coverage new/current, TBPL]: The changes follows spec and we have tested with real devices, it works good.
[Risks and why]: low
[String/UUID change made/needed]: NA
Attachment #8486437 - Flags: approval-mozilla-aurora?
Comment on attachment 8486437 [details] [diff] [review]
Bug 1064647 - B2G RIL: treat 0x90, 0x91, 0x9E and 0x9F as a success results for sw1 regarding ICC_IO. r=Edgar.

Approving due to same reason as https://bugzilla.mozilla.org/show_bug.cgi?id=1061380#c19 and NI anshul so he's aware of these RIL changes and can raise any major concerns.
Attachment #8486437 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Flags: needinfo?(anshulj)
Thanks Bhavana.
Flags: needinfo?(anshulj)
Depends on: 1080770
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: