1064819 - Search Activity does not work in landscape mode on Gingerbread devices

Status: RESOLVED WORKSFORME

(Firefox for Android Graveyard :: Search Activity, defect)

Description

[Flaviu Cos]

Environment: 
Device: Samsung Galaxy R (Android 2.3.4);
Build: Nightly 35.0a1 (2014-09-08);

Steps to reproduce:
1. Launch Search Activity;
2. Rotate the device to landscape mode.

Expected result:
Search Activity is rotating to landscape mode.

Actual result:
The Search Activity works only in portrait mode.

Notes:
This issue is specific to Gingerbread devices.

Comment 1

[Kevin Brosnan [Ex-Mozilla]]

Do we even want to ship the search activity on Gingerbread?

Comment 2

[:Margaret Leibovic]

(In reply to Kevin Brosnan [:kbrosnan] from comment #1)
> Do we even want to ship the search activity on Gingerbread?

Yes, we want to ship it where we ship Fennec. Even though the swipe-up action doesn't exist on gingerbread, the user could still launch the search activity from the search widget.

Comment 3

[Kevin Brosnan [Ex-Mozilla]]

How does this feature affect APK size. If we are making a low resource APK, bug 1039789 I don't know if shipping this activity makes sense.

Comment 4

[:Margaret Leibovic]

(In reply to Kevin Brosnan [:kbrosnan] from comment #3)
> How does this feature affect APK size. If we are making a low resource APK,
> bug 1039789 I don't know if shipping this activity makes sense.

I don't think the search activity will have nearly as much impact on APK size as the things we're doing in bug 1039789.

In any case, we can't just not include these resources for certain devices until we actually start shipping split APKs.

Comment 5

[Richard Newman [:rnewman]]

Yes, it's a call whether the search activity should ship on GB, and we should evaluate its footprint, but I imagine we'll err on the side of shipping everywhere. It's easy enough to do so, so I've added it to my list.

The shorter-term question remains: do we care about landscape orientation on Gingerbread? I posit that we do not, and so long as it doesn't crash or look awful, we should just WONTFIX this bug. If lots of people scream (and I can't imagine they would), we can reopen.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Margaret - Feel free to hand this out to another developer

Comment 7

[:Margaret Leibovic]

I can't reproduce this with the latest Nightly on a Nexus S. The search activity appears in landscape mode as you would expect.

Is this still a problem? Or is it a device-specific issue?

Comment 8

[Flaviu Cos]

Looks like this issue is no longer reproducible.
Tested on Samsung Galaxy R (Android 2.3.4).
Closing bug as worksforme.