1065006 - in-app product APIs cause 404s because of misinterpreted app origins

Status: VERIFIED FIXED

(Marketplace Graveyard :: Payments/Refunds, defect, P1)

Description

[Kumar McMillan [:kumar]]

See bug 1064690 for STR

When the dev hub makes an API request it does so like this:
https://marketplace.allizom.org/api/v1/payments/app%3A//fxpay.allizom.org/in-app/
which works locally on Django's runserver but not on our nginx web servers. Maybe it's the double slash, who knows.

Anyway, the origin is technically not encoded right. If you do it from JavaScript (which the fxpay lib does, the encoding looks like:
https://marketplace.allizom.org/api/v1/payments/app%3A%2F%2Ffxpay.allizom.org/in-app/

This seems to be a bug in Django's reverse: https://github.com/mozilla/zamboni/blob/master/mkt/developers/templates/developers/payments/in-app-products.html#L54
but needs more investigation.

Comment 1

[Kumar McMillan [:kumar]]

more info:

>>> from django.core.urlresolvers import reverse
>>> reverse('in-app-products-list', args=['app://fxpay.allizom.org'])
'/api/v1/payments/app%3A//fxpay.allizom.org/in-app/'

Comment 2

[Kumar McMillan [:kumar]]

I've proposed a patch for review: https://github.com/mozilla/zamboni/pull/2527

Comment 3

[Kumar McMillan [:kumar]]

fixed in the patch above. This will go on stage Wednesday at 12pm PST. We can push it sooner if you need it.

Comment 4

[Kumar McMillan [:kumar]]

Hmm, this patch works locally but not on our servers :(

Comment 5

[Kumar McMillan [:kumar]]

something is weird on the server. I filed bug 1065742

Comment 6

[Kumar McMillan [:kumar]]

The nginx fix from bug 1065742 has been applied to dev, stage, and pay-alt. It is in deploy notes for next push.

Comment 7

[[:AndreiH]]

This is now verified and fixed! Thanks !