1065186 - Turn off COWs for Arrays

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Bobby Holley (:bholley)]

My spidey senses tell me that, if we can successfully do bug 1065185, this may also be straightforward.

Comment 1

[Bobby Holley (:bholley)]

Note - If the landing of this bug breaks your code, you need to find a different way to expose Arrays to content. For DOM APIs, you should use WebIDL bindings. For extensions etc, you should use |new contentWindow.Array()| or |Cu.cloneInto(yourArray, contentWindow)|.

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=08d1df66f8a1

Comment 2

[Gabor Krizsanits (INACTIVE)]

CCing Matteo just in case since we had to resolve a breakage related to bug 1065185 in jetpack. I don't expect this one to cause any more issues but we'll see.

Comment 3

[Bobby Holley (:bholley)]

linux64 is green. Let's see about the rest of CI:

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=c7e99220354e

Comment 4

[Bobby Holley (:bholley)]

Attachment: Part 1 - Fix up test suite to not rely on COWed Arrays. v1

Comment 5

[Bobby Holley (:bholley)]

Attachment: Part 2 - Drop support for exposing privileged arrays to untrusted content. v1

Comment 6

[Gabor Krizsanits (INACTIVE)]

(In reply to Bobby Holley (:bholley) from comment #4)
> Created attachment 8504083 [details] [diff] [review]
> Part 1 - Fix up test suite to not rely on COWed Arrays. v1

Some changes of this patch seem to belong to Bug 1081990 no? Is it intentional that you add functions related tests here?

Comment 7

[Bobby Holley (:bholley)]

(In reply to Gabor Krizsanits [:krizsa :gabor] from comment #6)
> Some changes of this patch seem to belong to Bug 1081990 no? Is it
> intentional that you add functions related tests here?

I switched them over to Function to test a different kind of COW (aside from Object), before I started feeling ambitious about nuking Function COWs as well. ;-)

Anyway, I decided to do bug 1082450 before landing this bug, so I'm holding off on the patches here for the moment. Hopefully this should all land very soon.

Comment 8

[Gabor Krizsanits (INACTIVE)]

Comment on attachment 8504083 [details] [diff] [review]
Part 1 - Fix up test suite to not rely on COWed Arrays. v1

Review of attachment 8504083 [details] [diff] [review]:
-----------------------------------------------------------------

Alright let me know if you want me to review in it's current form then, but I guess then it might change soon, so I just cancel the review for now.

Comment 9

[Bobby Holley (:bholley)]

Attachment: Part 1 - Fix up test suite to not rely on COWed Arrays. v2

This is now rebased on top of bug 1082450. And doesn't do any shortsighted
Array => Function switches.

Comment 10

[Bobby Holley (:bholley)]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/d6aadffaf239
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/ce796ac8901b

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d6aadffaf239
https://hg.mozilla.org/mozilla-central/rev/ce796ac8901b