1081985 - Stop Remapping COWed standard prototypes

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Bobby Holley (:bholley)]

Way back when we still fancied COWs to be a suitable mechanism for exposing APIs, we thought it would be cute to make .forEach work automatically on COWed arrays without adding it to __exposedProps__. This gave way to the idea of remapping standard prototypes of COWed objects to the corresponding prototype in the content compartment (bug 760109). This made sense at the time, but required a lot of really ugly/scary code that was hard to reason about.

We're getting close to being able to remove this functionality entirely. This would be _awesome_, because it would let us more or less rm ChromeObjectWrapper.cpp. I'll file some dependent bugs.

Comment 1

[Bobby Holley (:bholley)]

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=b7689fb6a631

Comment 2

[Bobby Holley (:bholley)]

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=8d397639a027

Comment 3

[Bobby Holley (:bholley)]

Attachment: Part 1 - Move checkPassToPrivilegedCode to AccessCheck.cpp where it belongs. v1

Comment 4

[Bobby Holley (:bholley)]

Attachment: Part 2 - Remove prototype remapping and make COWs simple. v1

\o/

Comment 5

[Bobby Holley (:bholley)]

Comment on attachment 8507335 [details] [diff] [review]
Part 2 - Remove prototype remapping and make COWs simple. v1

Gabor is on PTO, so I'll give bz the honor of reviewing the final slaughterhouse patches. :-)

Comment 6

[Bobby Holley (:bholley)]

\o/ \o/ \o/

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/17c8a8ce0ea8
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/7aed94d1f1a6

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/17c8a8ce0ea8
https://hg.mozilla.org/mozilla-central/rev/7aed94d1f1a6