1065190 - [meta] Improve Android version conditionalization

Status: RESOLVED WORKSFORME

(Firefox for Android Graveyard :: General, defect)

Description

[Richard Newman [:rnewman]]

We have a bunch of code scattered throughout the tree that does one of two things:

* Supports Android 2.2 and earlier.

* Conditionalizes between different Android versions at runtime.

We should improve this situation in two ways: kill the former, and allow the latter to be preprocessed via the SDK range mechanism.

This will result in a smaller libxul and a happier rnewman.


Obsolete code:

tools/profiler/LulRWLock.h

widget/android/AndroidBridge.cpp
825:        // Android 2.2+ (API level 8)

intl/icu/source/common/unicode/platform.h
565:     * Android before Gingerbread (Android 2.3, API level 9) did not support wchar_t.

media/libcubeb/src/cubeb_audiotrack.c (Bug 1041882)
60:                * we are on a Froyo (Android 2.2) device. */
183:     * around line 181 for Android 2.2 */

media/webrtc/trunk/webrtc/modules/audio_device/audio_device_impl.cc
289:      // Fall back to this case if on Android 2.2/OpenSLES not available.

media/webrtc/trunk/webrtc/system_wrappers/source/rw_lock.cc
35:  // Android 2.2 and before do not have POSIX pthread rwlocks.



Conditionalizes (much harder to find, help wanted):

Bug 1041882


Tests that we might be able to turn back on:

xpcom/tests/unit/xpcshell.ini
56:# Bug 902081: test fails consistently on Android 2.2, passes on 4.0

dom/canvas/test/reftest/reftest.list
12:# Android 2.2 ARMv6 slaves can't seem to use WebGL, but we can't seem to

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Not critical for bug 1100361

Comment 2

[Nick Alexander :nalexander [he/him]]

We've largely worked through these things.