1065219 - Simplify MSR::SelectReader and reject incompatible tracks at initialization time

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Comment 1

[Matthew Gregan [:kinetik]]

Attachment: Move track format rejection from switch to init time.

Comment 2

[Matthew Gregan [:kinetik]]

Attachment: Move track format rejection from switch to init time.

Comment 3

[Matthew Gregan [:kinetik]]

It makes more sense to reject incompatible tracks early, so move rejection to TrackBuffer::RegisterDecoder (so that incompatible tracks are never added to the set of active decoders), and remove the similar check from SelectReader.  This also drops the work-around EOS queue check from SelectReader, since it doesn't work as intended and only serves to confuse.

Comment 4

[cajbir (:cajbir)]

What does this patch apply on top of? I can't get it to apply.

Comment 5

[Matthew Gregan [:kinetik]]

Attachment: Move track format rejection from switch to init time. v2

Not sure now, here's a rebase from my current queue.  This applies on top of:

Bug 1064705
Bug 1062666
Bug 1062657
Bug 1065218

Comment 6

[cajbir (:cajbir)]

Bug 1065218 appears to rely on changes in this patch and vice versa. I can't apply 1065218 to apply this one on top.

Comment 7

[Matthew Gregan [:kinetik]]

I thought I uploaded rebased versions of them all, but it looks like it only did this one.  Fixed now, please try again.

Comment 8

[cajbir (:cajbir)]

(In reply to Matthew Gregan [:kinetik] from comment #7)
> I thought I uploaded rebased versions of them all, but it looks like it only
> did this one.  Fixed now, please try again.

Thanks, that worked.

Comment 9

[Matthew Gregan [:kinetik]]

https://tbpl.mozilla.org/?tree=Try&rev=23a9c04f3dd3

Comment 10

[Matthew Gregan [:kinetik]]

https://tbpl.mozilla.org/?tree=Try&rev=051ae6e82879

Comment 11

[Matthew Gregan [:kinetik]]

https://tbpl.mozilla.org/?tree=Try&rev=6d088441b611

Comment 12

[Matthew Gregan [:kinetik]]

https://tbpl.mozilla.org/?tree=Try&rev=574681747a04

https://hg.mozilla.org/integration/mozilla-inbound/rev/ed5f95178615

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ed5f95178615