Closed
Bug 1065420
Opened 10 years ago
Closed 10 years ago
[Status Bar] Camera should be using the dark grey status bar
Categories
(Firefox OS Graveyard :: Gaia::Camera, defect)
Tracking
(b2g-v2.0 wontfix, b2g-v2.0M wontfix, b2g-v2.1 verified, b2g-v2.2 verified)
RESOLVED
FIXED
2.1 S5 (26sep)
People
(Reporter: epang, Assigned: mikehenrty)
References
Details
(Keywords: polish, Whiteboard: [systemsfe])
Attachments
(2 files)
3.11 MB,
image/jpeg
|
Details | |
46 bytes,
text/x-github-pull-request
|
wilsonpage
:
review+
bajaj
:
approval-gaia-v2.1+
|
Details | Review |
Currently the status bar is black - we should update to match media apps (dark grey).
Assignee | ||
Updated•10 years ago
|
Assignee | ||
Comment 1•10 years ago
|
||
Eric, I was unable to see the statusbar in camera. It looks like it's a fullscreen app. Where were you seeing the black statusbar?
Flags: needinfo?(epang)
Assignee | ||
Comment 2•10 years ago
|
||
Oh, nm. You can pull down the statusbar the same way you can with the utility tray. Ok, I'll fix this.
Flags: needinfo?(epang)
Assignee | ||
Comment 3•10 years ago
|
||
Wilson, will you take a look? This just changes the color of the statusbar in camera when you try to open the utility tray.
Attachment #8487563 -
Flags: review?(wilsonpage)
Updated•10 years ago
|
Attachment #8487563 -
Flags: review?(wilsonpage) → review+
Assignee | ||
Comment 4•10 years ago
|
||
master: https://github.com/mozilla-b2g/gaia/commit/71b8620f6bb5d50640b59b936c1c9cebdd07b434
Status: NEW → RESOLVED
Closed: 10 years ago
status-b2g-v2.0:
--- → wontfix
status-b2g-v2.0M:
--- → wontfix
status-b2g-v2.1:
--- → affected
status-b2g-v2.2:
--- → fixed
Resolution: --- → FIXED
Assignee | ||
Comment 5•10 years ago
|
||
Comment on attachment 8487563 [details] [review] [Gaia PR] add theme color for camera [Approval Request Comment] [Bug caused by] (feature/regressing bug #): bug 1013913 [User impact] if declined: Camera status bar will not match other media apps. [Testing completed]: Locally tested, and ui-reviewed. [Risk to taking this patch] (and alternatives if risky): Low risk, meta tag change only. [String changes made]: none
Attachment #8487563 -
Flags: approval-gaia-v2.1?(fabrice)
Comment 6•10 years ago
|
||
Comment on attachment 8487563 [details] [review] [Gaia PR] add theme color for camera super low risk html change changing the color, looks good to land on 2.1
Attachment #8487563 -
Flags: approval-gaia-v2.1?(fabrice) → approval-gaia-v2.1+
Assignee | ||
Comment 7•10 years ago
|
||
v2.1: https://github.com/mozilla-b2g/gaia/commit/66af962728700c6d2cc13e93f8ed5d122305185a
Updated•10 years ago
|
Target Milestone: --- → 2.1 S5 (26sep)
You need to log in
before you can comment on or make changes to this bug.
Description
•