Closed Bug 1065997 Opened 5 years ago Closed 5 months ago

Update localized search plugins to use rel="searchform"

Categories

(Firefox :: Search, defect, P4)

defect

Tracking

()

RESOLVED WONTFIX

People

(Reporter: mak, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [partnerengine][fxsearch])

Once bug 990799 is done and tested for en-US, we should updated the localized search plugins too.
Flags: firefox-backlog+
Flags: qe-verify?
I was peeking at the discussion on #fx-team about bug 990799, and the impression is that not all searchplugins can be modified 

What is the reasoning behind this change? Meaning: what do we gain in terms of features, etc.

Because between this and the idea of making https a requirement that I read in another post, it starts to become scary.
The benefit is that we avoid having to update two URLs when updating search plugins, and the behavior between "empty searches" and normal searches is more consistent.

Consistency is most important when Mozilla-specific referral codes are involved, so for l10n plugins that likely means Yahoo/Google.
OK. If we're talking about referrals. it might include eBay and Amazon: eBay is pending an update, I never had to do updates to Amazon so far, so I'm not really sure of the situation either.

Google and Bing are centralized, so it's not really an issue. But, then we have the odd one (Japanese).

Mike, do you know if we still need that? I read bug 534125 and bug 508793 and I don't really understand why only Japanese has these differences.
Flags: needinfo?(mconnor)
Priority: -- → P4
Whiteboard: [fxsearch]
Whiteboard: [fxsearch] → [fxsearch][partnerengine]
Rank: 45
Whiteboard: [fxsearch][partnerengine] → [partnerengine][fxsearch]
Is this something we're still interested in doing? Searchplugins are now centralized, so it would be a single patch against mozilla-central
Flags: needinfo?(mconnor) → needinfo?(mozilla)
Bug 990799 provided no detail on the "Why". Is it just a correctness issue?
Flags: needinfo?(mozilla)
(In reply to Mike Kaply [:mkaply] from comment #5)
> Bug 990799 provided no detail on the "Why". Is it just a correctness issue?

I had a needinfo open for over 3 years from mconnor, at this point I have no clue. As far as I'm concerned, we should WONTFIX this and add rel="searchform" for new searchplugins, or when touching old ones.
(In reply to Mike Kaply [:mkaply] from comment #5)
> Bug 990799 provided no detail on the "Why". Is it just a correctness issue?

Using rel="searchform" typically makes us send affiliate codes (and process the 'purpose' value to send the correct one), whereas <SearchForm> typically doesn't.
> Using rel="searchform" typically makes us send affiliate codes (and process the 'purpose' value to send the correct one), whereas <SearchForm> typically doesn't.

That makes a difference at least for Yandex and Yahoo. We should at least update those (and test).

Since the switch to moving everything into mozilla-central and also to WebExtensions, I believe this is no longer relevant.

Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.