1066033 - Use orange text selection handles in search bar

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Search Activity, defect)

Description

[:Margaret Leibovic]

A bit of polish for the search activity.

It would also be nice to use orange as the highlight color for the action bar, but I'm not sure how to do that.

Comment 1

[:Margaret Leibovic]

Attachment: Use orange text selection handles in search bar

Wes, do you know how I can change the color of the action bar highlight as well?

Also, I just made copies of the xhdpi resources in fennec-search so that it will still build, but `grunt export` won't export them since they already exist in mozilla-central.

Comment 2

[Wesley Johnston (:wesj)]

Comment on attachment 8487877 [details] [diff] [review]
Use orange text selection handles in search bar

Review of attachment 8487877 [details] [diff] [review]:
-----------------------------------------------------------------

I assume the highlight is http://developer.android.com/reference/android/widget/TextView.html#attr_android:textColorHighlight

We set that in our theme for Fennec, so it applies to everything.

Comment 3

[:Margaret Leibovic]

(In reply to Wesley Johnston (:wesj) from comment #2)
> Comment on attachment 8487877 [details] [diff] [review]
> Use orange text selection handles in search bar
> 
> Review of attachment 8487877 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I assume the highlight is
> http://developer.android.com/reference/android/widget/TextView.
> html#attr_android:textColorHighlight
> 
> We set that in our theme for Fennec, so it applies to everything.

Are you suggesting I should remove that from this TextView? I found I needed to add that myself at one point, but perhaps that was for the standalone search activity.

Comment 4

[:Margaret Leibovic]

https://github.com/mozilla/fennec-search/commit/e533b8ee577db020f3df215c57a4463b543428e0
https://hg.mozilla.org/integration/fx-team/rev/69d5ff91f0aa

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/69d5ff91f0aa

Comment 6

[Flaviu Cos]

Text selection handles in search results are blue. Is this as expected?

Comment 7

[:Margaret Leibovic]

(In reply to Flaviu Cos, QA [:flaviu] from comment #6)
> Text selection handles in search results are blue. Is this as expected?

Yes, this is because this is a WebView, so we're just using the defaults that are there. Perhaps it could be worth filing a separate bug to update this, but I don't know that it's really important, since we may eventually move away from the WebView.

Comment 8

[Flaviu Cos]

Verified as fixed in build 36.0a1 2014-11-17;
Device: Asus Transformer Tab (Android 4.0.3).