Use orange text selection handles in search bar

VERIFIED FIXED in Firefox 36

Status

()

Firefox for Android
Search Activity
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: Margaret, Assigned: Margaret)

Tracking

(Blocks: 1 bug)

Trunk
Firefox 35
All
Android
Points:
---

Firefox Tracking Flags

(firefox36 verified)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
A bit of polish for the search activity.

It would also be nice to use orange as the highlight color for the action bar, but I'm not sure how to do that.
(Assignee)

Comment 1

3 years ago
Created attachment 8487877 [details] [diff] [review]
Use orange text selection handles in search bar

Wes, do you know how I can change the color of the action bar highlight as well?

Also, I just made copies of the xhdpi resources in fennec-search so that it will still build, but `grunt export` won't export them since they already exist in mozilla-central.
Attachment #8487877 - Flags: review?(wjohnston)
Comment on attachment 8487877 [details] [diff] [review]
Use orange text selection handles in search bar

Review of attachment 8487877 [details] [diff] [review]:
-----------------------------------------------------------------

I assume the highlight is http://developer.android.com/reference/android/widget/TextView.html#attr_android:textColorHighlight

We set that in our theme for Fennec, so it applies to everything.
Attachment #8487877 - Flags: review?(wjohnston) → review+
(Assignee)

Comment 3

3 years ago
(In reply to Wesley Johnston (:wesj) from comment #2)
> Comment on attachment 8487877 [details] [diff] [review]
> Use orange text selection handles in search bar
> 
> Review of attachment 8487877 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I assume the highlight is
> http://developer.android.com/reference/android/widget/TextView.
> html#attr_android:textColorHighlight
> 
> We set that in our theme for Fennec, so it applies to everything.

Are you suggesting I should remove that from this TextView? I found I needed to add that myself at one point, but perhaps that was for the standalone search activity.
(Assignee)

Comment 4

3 years ago
https://github.com/mozilla/fennec-search/commit/e533b8ee577db020f3df215c57a4463b543428e0
https://hg.mozilla.org/integration/fx-team/rev/69d5ff91f0aa
https://hg.mozilla.org/mozilla-central/rev/69d5ff91f0aa
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35

Comment 6

3 years ago
Text selection handles in search results are blue. Is this as expected?
(Assignee)

Comment 7

3 years ago
(In reply to Flaviu Cos, QA [:flaviu] from comment #6)
> Text selection handles in search results are blue. Is this as expected?

Yes, this is because this is a WebView, so we're just using the defaults that are there. Perhaps it could be worth filing a separate bug to update this, but I don't know that it's really important, since we may eventually move away from the WebView.

Comment 8

3 years ago
Verified as fixed in build 36.0a1 2014-11-17;
Device: Asus Transformer Tab (Android 4.0.3).
Status: RESOLVED → VERIFIED
status-firefox36: --- → verified
You need to log in before you can comment on or make changes to this bug.