1066149 - Regressions in bottom panel: resizing broken

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P2)

Description

[William Lachance (:wlach)]

There have been two regressions in bottom panel behaviour:

1. It can get really big if there's lots of job details or failure lines. We should cap the size of these panels and use scrollbars for overflow.
2. At some point (possibly due to the flexbox refactoring, not sure), resizing the bottom panel broke. Regardless of what broke it, I don't think the current approach will work with flexbox. Let's experiment with using another library for this, like http://rightjs.org/ui/resizable

Comment 1

[William Lachance (:wlach)]

It looks like the "grow too big" problem has already been addressed with a change to max-height inside the bottom panel in bug 1053985, so let's restrict the scope of this bug to resizing.

Comment 2

[William Lachance (:wlach)]

Attachment: Re-add bottom panel resizing

Wound up using the angular solution, I think it works pretty well.

Comment 3

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/50e3b815e8f594580d72ebe148297d7b3ce7451f
Bug 1066149 - Make resizing work on bottom panel again

https://github.com/mozilla/treeherder-ui/commit/3c944d42fc5443224d5268873a1b10e1af3cebcd
Merge pull request #170 from wlach/1066149

Bug 1066149 - Make resizing work on bottom panel again

Comment 4

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/84cbaea13785823b477dae90c108c1074c144b6f
Revert "Bug 1066149 - Make resizing work on bottom panel again"

This reverts commit 50e3b815e8f594580d72ebe148297d7b3ce7451f.

Comment 5

[Ed Morley [:emorley]]

Unfortunately this broke the log viewer. I've reverted it for now, rather than adding the resizer.js script to logviewer.html, since it would be unused there (at least for now - though perhaps the resizer would be nice there as well?)

I've also filed bug 1067000 for adding tests for the log viewer, since Travis remained green throughout.


Error: [$injector:modulerr] Failed to instantiate module logViewer due to:
[$injector:modulerr] Failed to instantiate module treeherder due to:
[$injector:modulerr] Failed to instantiate module mc.resizer due to:
[$injector:nomod] Module 'mc.resizer' is not available! You either misspelled the module name or forgot to load it. If registering a module ensure that you specify the dependencies as the second argument.
http://errors.angularjs.org/1.2.16/$injector/nomod?p0=mc.resizer
minErr/<@http://treeherder-dev.allizom.org/ui/vendor/angular/angular.js:78:12
module/<@http://treeherder-dev.allizom.org/ui/vendor/angular/angular.js:1611:1
ensure@http://treeherder-dev.allizom.org/ui/vendor/angular/angular.js:1535:38
module@http://treeherder-dev.allizom.org/ui/vendor/angular/angular.js:1609:1
loadModules/<@http://treeherder-dev.allizom.org/ui/vendor/angular/angular.js:3781:22
forEach@http://treeherder-dev.allizom.org/ui/vendor/angular/angular.js:323:7
loadModules@http://treeherder-dev.allizom.o

Comment 6

[William Lachance (:wlach)]

Attachment: Fix logviewer brokenness

Same great patch, less logviewer brokenness

Comment 7

[William Lachance (:wlach)]

(In reply to Ed Morley [:edmorley] from comment #5)
> Unfortunately this broke the log viewer. I've reverted it for now, rather
> than adding the resizer.js script to logviewer.html, since it would be
> unused there (at least for now - though perhaps the resizer would be nice
> there as well?)

I think it's fine just to include the resizer js module in the logviewer page for now (it doesn't cause any real harm), so that's what I did in my updated patch. Can always change approach later.

Comment 8

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/f2e8e1bba63f424633836bcecb9283042722eadf
Bug 1066149 - Make resizing work on bottom panel again

(fixes issue in previous patch which broke logviewer)

https://github.com/mozilla/treeherder-ui/commit/95d5abf96f48bd0c6c8978ce0c1d70eb5b33063f
Merge pull request #183 from wlach/1066149

Bug 1066149 - Make resizing work on bottom panel again

Comment 9

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/ced6b2134fd3f1a6a852b929fa2a06acd9b3866e
Bug 1066149 - Make resizing work on bottom panel again

https://github.com/mozilla/treeherder/commit/cf6ba0a72d1b6fc18ccdbe98fef670e19badbbda
Merge pull request #170 from wlach/1066149

Bug 1066149 - Make resizing work on bottom panel again

https://github.com/mozilla/treeherder/commit/94ccb275426b61abca6c124712e94c5cc2c81c26
Revert "Bug 1066149 - Make resizing work on bottom panel again"

This reverts commit 50e3b815e8f594580d72ebe148297d7b3ce7451f.

https://github.com/mozilla/treeherder/commit/80e3d74f0255be43ad1cb742d374e051b255179c
Bug 1066149 - Make resizing work on bottom panel again

(fixes issue in previous patch which broke logviewer)

https://github.com/mozilla/treeherder/commit/1781c159b8dafadddb693d13c390aaaae6ec7593
Merge pull request #183 from wlach/1066149

Bug 1066149 - Make resizing work on bottom panel again