106631 - Regression: Specifying a port for SMTP server no longer works

Status: VERIFIED DUPLICATE of bug 52330

(MailNews Core :: Networking: SMTP, defect, P1)

Description

[Kai Engert [:KaiE:]]

In the past, even with the 0.9.4 branch, it was possible to enter the hostname
for the smtp server in host:port notation. As Mailnews does not provide a
separate GUI for specifying the port name of the server, this was the only way
of using a nonstandard port.

With the current trunk of Mozilla this does no longer work.

To reproduce this, you need a smtp server running on a port different from 25.

Set smtp hostname to hostname:port. Send a mail. Mozilla complains with the
error message "cannot connect to server".

This is caused by NS_MsgBuildSmtpUrl, which always appends ":25" to the smtp
hostname.

Comment 1

[Kai Engert [:KaiE:]]

Attachment: Suggested fix

Comment 2

[R.K.Aa.]

*** Bug 106630 has been marked as a duplicate of this bug. ***

Comment 3

[R.K.Aa.]

*** Bug 106629 has been marked as a duplicate of this bug. ***

Comment 4

[R.K.Aa.]

*** Bug 106628 has been marked as a duplicate of this bug. ***

Comment 5

[Kai Engert [:KaiE:]]

Attached patch checks for present colon, and only appends colon/portname if
necessary.

Adding patch, review keywords, P1 because we have a patch.

Comment 6

[Håkan Waara]

The patch looks good to me, although I would prefer if you use New World strings. :)

Adding naving and bienvenu for official r=/sr= as I do not feel confident
reviewing this code.

Comment 7

[Kai Engert [:KaiE:]]

Attachment: New patch, using new world strings ;-)

Comment 8

[Olav Vitters]

*** Bug 107529 has been marked as a duplicate of this bug. ***

Comment 9

[Kai Engert [:KaiE:]]

Please review my simple patch.

Comment 10

[scottputterman]

*** Bug 86648 has been marked as a duplicate of this bug. ***

Comment 11

[Kai Engert [:KaiE:]]

Nominating for 0.9.6. I know we are late, but it is a simple fix.

Please re-target if approriate.

Comment 12

[Scott MacGregor]

hey kai, this is not a 096 blocker so I'm going to move this off to 097. In
addition the mailnews module is focusing on footprint & performance (see Seth's
posting in the mailnewsgroup) right now and this bug fix doesn't fall along
those lines. We're trying to discourage changes that don't help us move forward
in those areas right now. 

Also, I'd rather not fix this with a hack but I have another bug which asks us
to properly allow you to specify a port for smtp via the account manager dialog
just like you can for imap and news. So I'd rather take the time to do it with a
UI and what not. 

Comment 13

[scottputterman]

moving to 0.9.9, but if you want this to be the same bug as the UI one (don't
know what that one is) feel free to dup one of them.

Comment 14

[Denis Antrushin]

FYI, UI bug number is 52330 

Comment 15

[peter]

I can no longer use mozilla outside the office, because I cannot target an 
ssh tunnel.  This is serious, as in mailer not functional, show stopper 
stuff to me.  my laptop is now several pounds of scrap metal.

By all means, add GUI configuration to this feature at some point,
but in the mean time, please fix it, so that something functional is
available.    As things stand, I can no longer use your application.

Comment 16

[Denis Antrushin]

Peter, bug 52330 also has patch attached. 
But I think we have nothing else but wait until 0.9.8 is out, since
mailnews currently has other priorities (perf & footprinf), so 
there is no much chances that these patches will be reviewed/checked in, 
sorry.

Comment 17

[Håkan Waara]

Obviously, this is a bad regression that blocks some people from using the
product altogether. Furthermore, there is a patch. As I interpret it, the
mailnews semi lock-down is supposed to accept *regression* fixes.

There's a fix attached to the bug, can someone familiar with the code please
review it so kaie can check it in?

Comment 18

[Milos Kleint]

I wonder if the user could temporarily get around the problem by editing the
prefs file. If so how? (for me it's also quite unpleasant bug)

Comment 19

[Kai Engert [:KaiE:]]

I don't think editing the prefs can help. There is currently no separate storage
for storing the port number. It is just that the underlying network layer is
able to deal with host name strings that include a :port number. Whatever you
put in the prefs, the broken code will add :25, which will make the underlying
network layer connect to port 25.

Comment 20

[Peter Bäck]

Showstopper for me also, please fix soon, won't mind a temporary fix. 
Can't be to hard to do?

//Peter

Comment 21

[Jens Krinke]

It used to work, 0.9.5 broke it, it is a showstopper for me and 0.99 is too far
away.

Comment 22

[John Unruh]

*** Bug 98372 has been marked as a duplicate of this bug. ***

Comment 23

[Jerome Lacoste]

As I noted in bug 52330, patch for bug 52330 could be split into 2 parts, thus
allowing for the back end of the patch to be applied first, solving that bug and
preventing us to put a hack here (even the hack seems safe).
One will then be able to use the preferences to solve the problem.
I suggest then to vote for bug 52330, (for the backend part).

Backend part seems pretty safe even if its bigger than this patch.
It is merely some a couple of get/set, and one new parameter added to some methods.

Comment 24

[Martin Renner]

This bug makes mozilla useless for me - at home and at work.

As there is already a patch, 0.9.9 is too far away.

Comment 25

[johan]

FYI, the attached patch works with the mozilla 0.9.6 source for those who can
compile themselves.

Comment 26

[Christian :Biesinger (don't email me, ping me on IRC)]

Bug 52330 is the same as this one.
Also, it has a better patch.

Marking as duplicate.
Please reopen if you don't agree.

*** This bug has been marked as a duplicate of 52330 ***

Comment 27

[Ninoschka Baca]

Verified Duplicate.