Closed
Bug 1066483
Opened 10 years ago
Closed 10 years ago
Update SVG camelCase knowledge to omit names dropped from the spec
Categories
(Core :: DOM: HTML Parser, defect)
Core
DOM: HTML Parser
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: hsivonen, Assigned: hsivonen)
References
Details
Attachments
(3 files)
14.98 KB,
patch
|
wchen
:
review+
|
Details | Diff | Splinter Review |
81.04 KB,
patch
|
wchen
:
review+
|
Details | Diff | Splinter Review |
1004 bytes,
patch
|
jgraham
:
review+
|
Details | Diff | Splinter Review |
Some SVG camelCase attributes have been dropped by the SVG WG and then dropped by the HTML spec. I'm not sure how good an idea it is to tweak this stuff, but since Blink has already tweaked their parser (except for filterRes), I guess it's too late to second-guess this direction.
Assignee | ||
Comment 1•10 years ago
|
||
Assignee | ||
Comment 2•10 years ago
|
||
The test file update comes verbatim from upstream.
Assignee | ||
Comment 3•10 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=27739c8f0d9e
Assignee | ||
Updated•10 years ago
|
Attachment #8488490 -
Flags: review?(wchen)
Assignee | ||
Updated•10 years ago
|
Attachment #8488502 -
Flags: review?(wchen)
Comment 4•10 years ago
|
||
Comment on attachment 8488502 [details] [diff] [review] Gecko patch Review of attachment 8488502 [details] [diff] [review]: ----------------------------------------------------------------- For contentStyleType and contentScriptType, we should probably remove the comments here too: http://dxr.mozilla.org/mozilla-central/source/content/base/src/nsTreeSanitizer.cpp#396 It looks like there is already a bug for removing the parsing of filterRes (bug 979472), we should also get rid of these gecko bits since they aren't being used anywhere: http://dxr.mozilla.org/mozilla-central/source/content/base/src/nsGkAtomList.h#1326 http://dxr.mozilla.org/mozilla-central/source/content/base/src/nsTreeSanitizer.cpp#419 r=me with those changes.
Attachment #8488502 -
Flags: review?(wchen) → review+
Updated•10 years ago
|
Attachment #8488490 -
Flags: review?(wchen) → review+
Assignee | ||
Comment 6•10 years ago
|
||
Thanks. Landed with the review comments addressed: https://hg.mozilla.org/integration/mozilla-inbound/rev/230ec8030aa7
Comment 7•10 years ago
|
||
Backed out for web platform test failures. https://hg.mozilla.org/integration/mozilla-inbound/rev/d180f7e3f608 https://tbpl.mozilla.org/php/getParsedLog.php?id=48472542&tree=Mozilla-Inbound
Comment 8•10 years ago
|
||
It looks like we have another copy of the html5lib tests in web platform tests, and it's failing due to unexpected test passes. We probably just need to delete this file: http://dxr.mozilla.org/mozilla-central/source/testing/web-platform/meta/html/syntax/parsing/html5lib_tests11.html.ini
Assignee | ||
Comment 9•10 years ago
|
||
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=86fe9e381cad
Assignee | ||
Updated•10 years ago
|
Attachment #8505344 -
Flags: review?(james)
Updated•10 years ago
|
Attachment #8505344 -
Flags: review?(james) → review+
Assignee | ||
Comment 10•10 years ago
|
||
Thanks. Landed: https://hg.mozilla.org/integration/mozilla-inbound/rev/9ec96af33898 https://hg.mozilla.org/integration/mozilla-inbound/rev/d435760a28dc
Comment 11•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/9ec96af33898 https://hg.mozilla.org/mozilla-central/rev/d435760a28dc
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Assignee | ||
Comment 12•10 years ago
|
||
https://hg.mozilla.org/projects/htmlparser/rev/7524c372f7f7
You need to log in
before you can comment on or make changes to this bug.
Description
•