1066498 - Fail gracefully if the target doesn't have a timeline actor

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect)

Description

[Paul Rouget [:paul]]

We should show a message in the timeline panel "Timeline not supported for this runtime". And make sure to avoid all these exceptions in the jsconsole ("gFront undefined").

Comment 1

[Jordan Santell [:jsantell] [@jsantell]]

Should we still support the tool itself, just show a message if the target isn't supported? Wouldn't it be more in line to just not have the panel itself supported within the toolbox for the target?

A message could be used within the performance tab once we have timeline moved in there, but for overall support, I think this should just be a toolbox setting.

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to Jordan Santell [:jsantell] [@jsantell] from comment #1)
> Should we still support the tool itself, just show a message if the target
> isn't supported? Wouldn't it be more in line to just not have the panel
> itself supported within the toolbox for the target?
> 
> A message could be used within the performance tab once we have timeline
> moved in there, but for overall support, I think this should just be a
> toolbox setting.

Yeah, I would say the tool should just not appear at all, as with other tools when they don't support a target.

Comment 3

[Jordan Santell [:jsantell] [@jsantell]]

The fix for this is a part of bug 1069673[1], resolving this

[1] https://github.com/mozilla/gecko-dev/blob/5373e7de91fe7b5c11ca7d44720e179ed8cfe407/browser/devtools/main.js#L316

Comment 4

[Andrei Vaida [:avaida]]

Setting qe-verify- for this fix, since it's already covered by automated testing via Bug 1069673. If there's anything manual QA should look at here, please flip the flag.

Comment 5

[David Lawrence [:dkl]]

Sorry for the spam. Moving bugs to Firefox :: Developer Tools: Performance Tools (Profiler/Timeline).

dkl