Closed Bug 1066634 Opened 7 years ago Closed 7 years ago

Tablet UI: make new Tablet configuration-related strings localizable

Categories

(Firefox for Android Graveyard :: Settings and Preferences, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 35

People

(Reporter: flod, Assigned: lucasr)

References

Details

Attachments

(1 file, 1 obsolete file)

Right now the string is not exposed to localization. 

Even if temporary, it makes sense to make it localizable and give Nightly users a consistent experience in the menu.
Component: General → Settings and Preferences
Are we planning on shipping this pref past Nightly?
Lucas has the final call, but given that he's asleep, I'll chime in: no, we don't plan for this to ship past Nightly.

As flod points out, this is to give a consistent experience to our non-English Nightly users.
Note that this should also apply to the toast that pops up after the new tablet UI is enabled.
Summary: Tablet UI: make the string 'Enable new tablet UI' localizable → Tablet UI: make new Tablet configuration-related strings localizable
Talked with Lucas on IRC before filing this bug: this should not go past nightly, but it's also probably going to stay for a couple of cycles too.

No point in displaying a mixed language menu when it comes down to only one string (or two based on comment 3).

Also, I've seen plans changing before, and things move to Aurora when they weren't supposed to :-)
Attachment #8490155 - Flags: review?(michael.l.comella)
Comment on attachment 8490735 [details] [diff] [review]
Make new Tablet configuration-related strings localizable (r=mcomella)

Forgot to remove the now obsolete comment in preferences_display.xml.
Attachment #8490735 - Flags: review?(michael.l.comella)
Attachment #8490155 - Attachment is obsolete: true
Attachment #8490155 - Flags: review?(michael.l.comella)
Assignee: nobody → lucasr.at.mozilla
Attachment #8490735 - Flags: review?(michael.l.comella) → review+
https://hg.mozilla.org/mozilla-central/rev/6c2940e4d283
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.