1066634 - Tablet UI: make new Tablet configuration-related strings localizable

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Settings and Preferences, defect)

Description

[Francesco Lodolo [:flod]]

Right now the string is not exposed to localization. 

Even if temporary, it makes sense to make it localizable and give Nightly users a consistent experience in the menu.

Comment 1

[Kevin Brosnan [Ex-Mozilla]]

Are we planning on shipping this pref past Nightly?

Comment 2

[Richard Newman [:rnewman]]

Lucas has the final call, but given that he's asleep, I'll chime in: no, we don't plan for this to ship past Nightly.

As flod points out, this is to give a consistent experience to our non-English Nightly users.

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Note that this should also apply to the toast that pops up after the new tablet UI is enabled.

Comment 4

[Francesco Lodolo [:flod]]

Talked with Lucas on IRC before filing this bug: this should not go past nightly, but it's also probably going to stay for a couple of cycles too.

No point in displaying a mixed language menu when it comes down to only one string (or two based on comment 3).

Also, I've seen plans changing before, and things move to Aurora when they weren't supposed to :-)

Comment 5

[Lucas Rocha (:lucasr)]

Attachment: Make new Tablet configuration-related strings localizable (r=mcomella)

Comment 6

[Lucas Rocha (:lucasr)]

Attachment: Make new Tablet configuration-related strings localizable (r=mcomella)

Comment 7

[Lucas Rocha (:lucasr)]

Comment on attachment 8490735 [details] [diff] [review]
Make new Tablet configuration-related strings localizable (r=mcomella)

Forgot to remove the now obsolete comment in preferences_display.xml.

Comment 8

[Lucas Rocha (:lucasr)]

https://hg.mozilla.org/integration/fx-team/rev/6c2940e4d283

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6c2940e4d283