Strictmode violation in SendTab ShareMethod init

RESOLVED FIXED in Firefox 35

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: ckitching, Assigned: ckitching)

Tracking

unspecified
Firefox 35
ARM
Android
Points:
---

Firefox Tracking Flags

(firefox34 wontfix, firefox35 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Comment 1

4 years ago
Created attachment 8488752 [details] [diff] [review]
Fix strictmode violation in sharing service

Initialisation of ShareMethods wasn't being forked onto the background thread as intended.
Attachment #8488752 - Flags: review?(rnewman)
Comment on attachment 8488752 [details] [diff] [review]
Fix strictmode violation in sharing service

Review of attachment 8488752 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/overlays/service/OverlayActionService.java
@@ +92,1 @@
>          shareTypes.clear();

Put this inside the Runnable, too.
Attachment #8488752 - Flags: review?(rnewman) → review+
https://hg.mozilla.org/mozilla-central/rev/2bcd3d508fe4
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
Comment on attachment 8488752 [details] [diff] [review]
Fix strictmode violation in sharing service

Dependency for feature we'd like to turn on in 34. Sorry for the late approval request.
Attachment #8488752 - Flags: approval-mozilla-beta?
Blocks: 1092409
This request is in support of bug 1092409. However, another dependency of this work, bug 1061721, requires string changes and cannot land on Beta as is. I'm holding off on approval for this bug until we determine whether we need to take this work on Beta.
Comment on attachment 8488752 [details] [diff] [review]
Fix strictmode violation in sharing service

We're not going to ship bug 1092409 in 34. As such, we don't need to uplift to this patch to Beta.
Attachment #8488752 - Flags: approval-mozilla-beta? → approval-mozilla-beta-
status-firefox34: --- → wontfix
status-firefox35: --- → fixed
You need to log in before you can comment on or make changes to this bug.