1066747 - Strictmode violation in SendTab ShareMethod init

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Overlays, defect)

Description

[Chris Kitching [:ckitching]]

Behold:

https://rnewman.pastebin.mozilla.org/6455079

Comment 1

[Chris Kitching [:ckitching]]

Attachment: Fix strictmode violation in sharing service

Initialisation of ShareMethods wasn't being forked onto the background thread as intended.

Comment 2

[Richard Newman [:rnewman]]

Comment on attachment 8488752 [details] [diff] [review]
Fix strictmode violation in sharing service

Review of attachment 8488752 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/overlays/service/OverlayActionService.java
@@ +92,1 @@
>          shareTypes.clear();

Put this inside the Runnable, too.

Comment 3

[Chris Kitching [:ckitching]]

https://hg.mozilla.org/integration/fx-team/rev/2bcd3d508fe4

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/2bcd3d508fe4

Comment 5

[Richard Newman [:rnewman]]

Comment on attachment 8488752 [details] [diff] [review]
Fix strictmode violation in sharing service

Dependency for feature we'd like to turn on in 34. Sorry for the late approval request.

Comment 6

[Lawrence Mandel [:lmandel] (use needinfo)]

This request is in support of bug 1092409. However, another dependency of this work, bug 1061721, requires string changes and cannot land on Beta as is. I'm holding off on approval for this bug until we determine whether we need to take this work on Beta.

Comment 7

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8488752 [details] [diff] [review]
Fix strictmode violation in sharing service

We're not going to ship bug 1092409 in 34. As such, we don't need to uplift to this patch to Beta.