1066869 - [Contacts] Contact photo does not appear when receiving a call.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[John Thomas [:Johnt]]

Attachment: logcat_20140911_1023.txt

Description: When a contact with a photo that was added to their information calls the user's phone no photo will appear.

Repro Steps:
1) Update a Flame to 20140912000203
2) Open Contacts App
3) Select the "+" icon to add a new contact.
4) Select "Add Picture".
5) Select a photo or take a photo.
6) Select Done.
7) Add a phone number to Contact.
8) Select done.
9) Receive a call from contact.

Actual: Contact does not have a photo when receiving a call from them.

Expected: It is expected that the contact photo will appear for the contact who is calling.

Flame 2.1

Environmental Variables:
Device: Flame 2.1 (319mb)
Build ID: 20140912000203
Gaia: 7fe8807b384e1867fa4322f49a1310126fc5a849
Gecko: 1d4b0fc511dc
Version: 34.0a2
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Notes: I was able to get a contact photo to appear one time on the Flame 2.1 Jellybean (319mb), but not another device with the same build. 

Repro frequency: 4/5
Link to failed test case: https://moztrap.mozilla.org/manage/case/1544/
See attached: Logcat and Screenshot.

Comment 1

[John Thomas [:Johnt]]

Attachment: 2014-09-12-14-53-54.png

Comment 2

[John Thomas [:Johnt]]

This issue DOES occur on the Open_C 2.2, Flame 2.1 (512mb) Flame 2.0 Kitkat Base (319mb), 

Description: Contact does not have a photo when receiving a call from them.

Open C 2.2

Environmental Variables:
Device: Open_C Master
Build ID: 20140912040204
Gaia: 6cb5e0100d70313e4922c8d34bf20dcdd66ef616
Gecko: 2db5b64f6d49
Version: 35.0a1 (Master)
Firmware Version: P821A10V1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Flame 2.1

Environmental Variables:
Device: Flame 2.1 (512mb)
BuildID: 20140912000203
Gaia: 7fe8807b384e1867fa4322f49a1310126fc5a849
Gecko: 1d4b0fc511dc
Version: 34.0a2 (2.1)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Flame 2.0 KitKat Base (319mb)

Environmental Variables:
Device: Flame 2.0
Build ID: 20140912000202
Gaia: 91dd0e596aa7c124dd968e1474b23e7992dc35a1
Gecko: a66168598533
Version: 32.0 (2.0)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0


============================================================================

This issues does NOT occur on the Flame 2.2 (319mb), Open_C 2.1, Flame 2.0 (319mb), Open_C 2.0, Flame 1.4 (319mb), Open_C 1.4 

Result: Contact has a photo when receiving a call from another device.

Flame 2.2

Environmental Variables:
Device: Flame Master (319mb)
Build ID: 20140912040204
Gaia: 6cb5e0100d70313e4922c8d34bf20dcdd66ef616
Gecko: 2db5b64f6d49
Version: 35.0a1 (Master)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Open C 2.1

Environmental Variables:
Device: Open_C 2.1
Build ID: 20140912000203
Gaia: 7fe8807b384e1867fa4322f49a1310126fc5a849
Gecko: 1d4b0fc511dc
Version: 34.0a2
Firmware Version: P821A10V1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Flame 2.0 (319mb)

Environmental Variables:
Device: Flame 2.0
Build ID: 20140912000202
Gaia: 91dd0e596aa7c124dd968e1474b23e7992dc35a1
Gecko: a66168598533
Version: 32.0 (2.0)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Open_C 2.0

Environmental Variables:
Device: Open_C 2.0
Build ID: 20140912000202
Gaia: 91dd0e596aa7c124dd968e1474b23e7992dc35a1
Gecko: a66168598533
Version: 32.0 (2.0)
Firmware Version: P821A10V1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Flame 1.4 (319mb)

Environmental Variables:
Device: Flame 1.4
Build ID: 20140912063006
Gaia: efa2b8cb095407df942fee7732a5547c7034ef9b
Gecko: f90055868023
Version: 30.0 (1.4)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0

Open C 1.4

Environmental Variables:
Device: Open_C 1.4
Build ID: 20140912063006
Gaia: efa2b8cb095407df942fee7732a5547c7034ef9b
Gecko: f90055868023
Version: 30.0 (1.4)
Firmware Version: P821A10V1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0

Comment 3

[KTucker [:KTucker][Inactive 3/4/2016]]

[Blocking Requested - why for this release]:

This is a regression from 1.4 and a major feature that should be present so nominating this 2.0?

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

Reassigning to the dialer component.

Doug are you familiar with this bug? Didn't check the code myself, but if it's a problem related to the thumbnail creationg, please forward it back to contacts.

Thanks!

Comment 6

[Maria Angeles Oteo (:oteo)]

Triage: Mayor functionality broken, it needs to be fixed in 2.0 and 2.1

Comment 7

[Anthony Ricaud (:rik)]

This is weird that we're having failures on some 2.0, 2.1 and 2.2 devices but not on some other 2.0, 2.1 and 2.2 devices.

Comment 8

[Anthony Ricaud (:rik)]

When the gallery activity closes, I see this error:
E/GeckoConsole( 1744): [JavaScript Error: "NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIContentPermissionRequest.allow]" {file: "jar:file:///system/b2g/omni.ja!/components/ContentPermissionPrompt.js" line: 154}]

And then, I don't even have a thumbnail for that contact in the contacts app.

Comment 9

[Anthony Ricaud (:rik)]

I had to restart the contacts app to see the thumbnails.

Comment 10

[Doug Sherk (:drs) (inactive)]

Clearing needinfo since Anthony is taking this, thanks!

Comment 11

[Francisco Jordano [:arcturus] [:francisco]]

About comment 8 and 9 whe have bug 1067427 to fix this thing.

But the photo is there, the photo and the thumbnail:
http://gyazo.com/33623bd0262ca71676fdc21b8604a0fc

Comment 12

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Bug 927862 seems to have caused this.

B2g-inbound Regression Window

Last working
Device: Flame 2.1
BuildID: 20140828211200
Gaia: 8d965e7182500fd1849e8eec5ae2aca35a55af22
Gecko: efb4f3f291a4
Version: 34.0a1 (2.1)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

First Broken
Environmental Variables:
Device: Flame 2.1
BuildID: 20140828223200
Gaia: 6f270b9fee0c1f09863f5e1aa640937a07c7fdae
Gecko: 18ed4643a705
Version: 34.0a1 (2.1)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.

Last working gaia / First broken gecko - Issue does NOT occur
Gaia: 8d965e7182500fd1849e8eec5ae2aca35a55af22
Gecko: 18ed4643a705

First broken gaia / Last working gecko - Issue DOES occur
Gaia: 6f270b9fee0c1f09863f5e1aa640937a07c7fdae
Gecko: efb4f3f291a4

Gaia Pushlog:  https://github.com/mozilla-b2g/gaia/compare/8d965e7182500fd1849e8eec5ae2aca35a55af22...6f270b9fee0c1f09863f5e1aa640937a07c7fdae

Comment 13

[Joshua Mitchell (Inactive)]

Broken by Bug 927862 ? can you take a look

Comment 14

[(inactive after 6/18) Alive Kuo [:alive]]

It seems callscreen is broken but I am sure why, could you kindly help?

Comment 15

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Jayme Mercado [:JMercado] from comment #12)
> Bug 927862 seems to have caused this.
> 
> B2g-inbound Regression Window
> 
> Last working
> Device: Flame 2.1
> BuildID: 20140828211200
> Gaia: 8d965e7182500fd1849e8eec5ae2aca35a55af22
> Gecko: efb4f3f291a4
> Version: 34.0a1 (2.1)
> Firmware Version: v123
> User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0
> 
> First Broken
> Environmental Variables:
> Device: Flame 2.1
> BuildID: 20140828223200
> Gaia: 6f270b9fee0c1f09863f5e1aa640937a07c7fdae
> Gecko: 18ed4643a705
> Version: 34.0a1 (2.1)
> Firmware Version: v123
> User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.
> 
> Last working gaia / First broken gecko - Issue does NOT occur
> Gaia: 8d965e7182500fd1849e8eec5ae2aca35a55af22
> Gecko: 18ed4643a705
> 
> First broken gaia / Last working gecko - Issue DOES occur
> Gaia: 6f270b9fee0c1f09863f5e1aa640937a07c7fdae
> Gecko: efb4f3f291a4
> 
> Gaia Pushlog: 
> https://github.com/mozilla-b2g/gaia/compare/
> 8d965e7182500fd1849e8eec5ae2aca35a55af22...
> 6f270b9fee0c1f09863f5e1aa640937a07c7fdae

Wait....bug 927862 is landed in master but not in v2.0, but according to comment 2, this issue is repro-ed on v2.0.....? Could you make sure?

Comment 16

[(inactive after 6/18) Alive Kuo [:alive]]

Well, I guess I know what happened, but not sure comment 2 said v2.0 is reproable. patch coming.

Comment 17

[(inactive after 6/18) Alive Kuo [:alive]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/24122

I talked to Carrie and she had confirmed we don't need to wait the transitionend of the callscreen to show the contact.

But there will be still a delay before showing the photo because we need some time to lookup the photo....I am not sure this is a regression or not (will try in v2.0 soon).

Sorry if this fix looks like a hack, is expecting you have some more better idea to clean up.

Comment 18

[Etienne Segonzac (:etienne)]

Comment on attachment 8490539 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/24122

The transition wait wasn't a UX request it was a technical decision because we were missing the transition altogether when the picture appeared during the opening sequence.

Now that the transition is done by the system app. looks like this isn't an issue anymore.

We obviously want to remove the _transitionDone altogether in the end but that should be part of bug 1054147. This patch is already making use move in the right direction.

r=me

Comment 19

[(inactive after 6/18) Alive Kuo [:alive]]

This bug should not be in v2.0; if v2.0 has the same issue(I don't see it?) it should be another bug.

Comment 20

[(inactive after 6/18) Alive Kuo [:alive]]

[Blocking Requested - why for this release]:
Regression from bug 927862, a feature for v2.1.

Comment 21

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8490539 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/24122

Canceling since no UX is changed so no ui-review needed.

Comment 22

[(inactive after 6/18) Alive Kuo [:alive]]

https://github.com/mozilla-b2g/gaia/commit/ead625fd4ffd84fda9393d5e451340b1937b4dea

Comment 23

[Joshua Mitchell (Inactive)]

(In reply to Alive Kuo [:alive][NEEDINFO!] from comment #15)
> (In reply to Jayme Mercado [:JMercado] from comment #12)
> > Bug 927862 seems to have caused this.

> Wait....bug 927862 is landed in master but not in v2.0, but according to
> comment 2, this issue is repro-ed on v2.0.....? Could you make sure?


Hi there - I think the confusion here is that the project is straddling KK vs JB firmware (base). In comment 2 the reporter indicates that this issue DOES repro in 2.0 with the KitKat base (V165) but does NOT repro in 2.0 with the JellyBean base (V123) 
The regression window was done with the JB base so indicated a first broken / last working in the 2.1 range because of this.

Hope that helps!

Comment 24

[Maria Angeles Oteo (:oteo)]

triage: 2.1+ bug.
It's a broken feature in 2.0 too. 

Regarding comment 23 Joshua says that the issue DOES repro in 2.0 with KitKat base (V165) but we are going to deliver devices based on kit kat for 2.0 so we need to fix this.

Anthony,Alive any idea about how to handle this? We were wondering if we could ask for approval to 2.0.

Comment 25

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Maria Angeles Oteo (:oteo) from comment #24)
> triage: 2.1+ bug.
> It's a broken feature in 2.0 too. 
> 
> Regarding comment 23 Joshua says that the issue DOES repro in 2.0 with
> KitKat base (V165) but we are going to deliver devices based on kit kat for
> 2.0 so we need to fix this.
> 
> Anthony,Alive any idea about how to handle this? We were wondering if we
> could ask for approval to 2.0.

If v2.0 really has this issue (and KK only) then it is another bug, please open followup.
I fixed this one because it's caused by bug 927862 which is landed in 2.1 and 2.2 only.

I cannot fix the v2.0 one, sorry.

Comment 26

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8490539 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/24122

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
Bug 927862 regression.
[User impact] if declined:
User will not see contact photo on callscreen.
[Testing completed]:
Yes
[Risk to taking this patch] (and alternatives if risky):
No
[String changes made]:
No

Comment 27

[Francisco Jordano [:arcturus] [:francisco]]

Hi Joshua,

based on comment #25, could you confirm that we still have this problem in 2.0 KK based?

As Alive suggested we will need to open a follow up to check what's the problem in that scenario.

Comment 28

[Anthony Ricaud (:rik)]

Also, if it's a problem with the KK build, it's probably not a Gaia issue so it makes sense to open another bug.

Comment 29

[Joshua Mitchell (Inactive)]

QA-Wanted to test 2.0 KK base in the latest.

Comment 30

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

I am unable to reproduce this issue on the latest 2.0 Flame KK build or the v180 2.0 Flame KK base. 15 attempts were tried on both with 0 reproductions (total 0/30).

Environmental Variables:
Device: Flame 2.0
BuildID: 20140917140111
Gaia: 31434a3949556171f3565ca47ac2b44e810e95e6
Gecko: cfedc95605d4
Version: 32.0 (2.0) 
Firmware Version: v165
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 31

[Joshua Mitchell (Inactive)]

(In reply to Francisco Jordano [:arcturus] [:francisco] from comment #27)
> Hi Joshua,
> 
> based on comment #25, could you confirm that we still have this problem in
> 2.0 KK based?
> 
> As Alive suggested we will need to open a follow up to check what's the
> problem in that scenario.

Not quite sure why but this no longer repo's on the 2.0 branch (kk based)

Comment 32

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/862521678b7e77ef606ec483caf50d549f78c34f

Comment 33

[pete siphantong [:Petes]]

This bug is verified fixed on the Flame 2.1 (319mb) and the Flame 2.2 (319mb)


Flame 2.2 Master KK (319mb) (Full Flash)

Device: Flame 2.2
BuildID: 20141010040202
Gaia: 1036b544b7e102592bd9fab95cd9317329ac1293
Gecko: 50b689feab5f
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 35.0a1 (2.2)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Flame 2.1 KK (319mb) (Full Flash)

Environmental Variables:
Device: Flame 2.1
BuildID: 20141010000201
Gaia: bc8eb493311c58f1f311a56b8b645b52bfbd2f71
Gecko: 72c13d8631ff
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 34.0a2 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Result: Contact photo will appear for the contact who is calling.