Open Bug 1066884 Opened 5 years ago Updated 1 year ago

Integrate Home Feeds add-on to Fennec

Categories

(Firefox for Android :: General, defect, P5)

x86_64
Linux
defect

Tracking

()

People

(Reporter: wesj, Assigned: karim, Mentored)

References

(Blocks 1 open bug, )

Details

(Whiteboard: [lang=java][lang=js])

Attachments

(1 file)

I've always wanted our feed reading to just be a built in thing in Fennec. Have we considered including the feeds add-on into fennec proper?

I neat bonus (IMO) if we can combine it with reader mode a bit. i.e. only show it if the page doesn't look readable? That would reduce the number of pageactions we're showing, and would make it dovetail nicely with reader mode. i.e. "This doesn't look like a readable article, but it does look like a page that contains a bunch of readable articles" We could even use some reader-type icon to avoid the bad connotations of "Rss".
Wes - Can you add this idea to the Project Roadmap Funnel's unprioritized list?
It would also be nice to make this part of our "reading list v2" effort.

If we fix bug 1007409, we could even add articles to the reader mode cache automatically. I think that has been Wes's dream forever.
Blocks: readerv2
Summary: Incorporate feed reader add-on into Fennec → Integrate Home Feeds addon into built
Summary: Integrate Home Feeds addon into built → Integrate Home Feeds addon into built-in home panel
Depends on: 1014163
No longer blocks: readerv2
Mentor: margaret.leibovic
Whiteboard: [lang=java][lang=js]
Margaret, does this really need bug 1014163 to land? Without it, it'd be pretty straightforward, right?
Flags: needinfo?(margaret.leibovic)
(In reply to Michael Comella (:mcomella) from comment #3)
> Margaret, does this really need bug 1014163 to land? Without it, it'd be
> pretty straightforward, right?

Yeah, this isn't a strict dependency.

Integrating the add-on *should* be pretty straightforward, although we have a different quality bar for something we ship vs. an add-on, so I think we may need to do some more work around reliably updating the feeds (and more importantly not kill the user's battery and data plan).

Now that we have bug 1007409, we could also do some interesting exploration around caching feed items for offline use... but that would be another bug.

I think it would be interesting to try moving forward with this but keeping it behind a pref, so that we could prevent it from riding the trains.
No longer depends on: 1014163
Flags: needinfo?(margaret.leibovic)
Assignee: nobody → kbenhmida
Summary: Integrate Home Feeds addon into built-in home panel → Integrate Home Feeds add-on to Fennec
Blocks: 1197408
No longer blocks: 1197408
Depends on: 1197408
Here's a link to a build with the addon built-in: http://d.pr/f/12WLb
This is a work in progress, there are some known issues (working on it):
* Removing a feed doesn't work properly (the panel is removed, but the feed stays in memory)
Comment on attachment 8657390 [details] [diff] [review]
WIP:  - Integrate Home Feeds add-on to Fennec

This is a WIP on integrating the add-on. Code looks messy now, I'm refactoring it to make it a module. Also rewriting some parts in Java.
Blocks: 1197408
No longer depends on: 1197408
Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195

Needinfo :susheel if you think this bug should be re-triaged.
Priority: -- → P5
You need to log in before you can comment on or make changes to this bug.