Closed
Bug 1066988
Opened 10 years ago
Closed 10 years ago
unittest picker_test.js using assert.include for testing object, not Array or string
Categories
(Firefox OS Graveyard :: Gaia::Clock, defect)
Firefox OS Graveyard
Gaia::Clock
Tracking
(Not tracked)
RESOLVED
FIXED
2.1 S6 (10oct)
People
(Reporter: sv99, Unassigned)
References
Details
Attachments
(2 files)
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:35.0) Gecko/20100101 Firefox/35.0
Build ID: 20140913030206
Steps to reproduce:
test('shape:prototype ', function() {
assert.ok(Picker);
assert.include(Picker.prototype, 'reset');
assert.include(Picker.prototype, 'value');
Picker.prototype - object not Array and not string.
chai used in test-agent simple do nothing in this case.
Write any value and test !!OK!!
assert.include(Picker.prototype, 'reset_reset');
Attachment #8489016 -
Flags: review?(m)
Updated•10 years ago
|
Attachment #8489016 -
Flags: review?(m) → review+
Attachment #8498745 -
Flags: review?(m)
Comment 3•10 years ago
|
||
Comment on attachment 8498745 [details] [review]
Link to PR (rebased)
The linter tests fail on your PR, saying "expect" is not defined.
Attachment #8498745 -
Flags: review?(m) → review-
Attachment #8498745 -
Flags: review- → review?(m)
Comment 5•10 years ago
|
||
Comment on attachment 8498745 [details] [review]
Link to PR (rebased)
thanks!
Attachment #8498745 -
Flags: review?(m) → review+
Keywords: checkin-needed
Comment 6•10 years ago
|
||
Status: UNCONFIRMED → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S6 (10oct)
Comment 7•10 years ago
|
||
This was backed out for not having a bug number in the commit. Commits which do not have bug numbers listed can cause a lot of headache down the road, so please ensure that commits always list the bug number. This is both the job of the author and reviewer to enforce.
I've gone ahead and re-landed this with the proper commit message, containing the bug number.
Backed out in: https://github.com/mozilla-b2g/gaia/commit/d1a29dc02e79dd1cfcd5847b5e8da9c7d65bebd9
Re-landed with the proper commit message: https://github.com/mozilla-b2g/gaia/commit/eb23ec537d5ec9459320a886dd893aca467711c3
You need to log in
before you can comment on or make changes to this bug.
Description
•