unittest picker_test.js using assert.include for testing object, not Array or string

RESOLVED FIXED in 2.1 S6 (10oct)

Status

Firefox OS
Gaia::Clock
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: sv99, Unassigned)

Tracking

unspecified
2.1 S6 (10oct)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

4 years ago
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:35.0) Gecko/20100101 Firefox/35.0
Build ID: 20140913030206

Steps to reproduce:

 test('shape:prototype ', function() {
    assert.ok(Picker);
    assert.include(Picker.prototype, 'reset');
    assert.include(Picker.prototype, 'value');

Picker.prototype - object not Array and not string.
chai used in test-agent simple do nothing in this case.

Write any value and test !!OK!!
assert.include(Picker.prototype, 'reset_reset');
(Reporter)

Comment 1

4 years ago
Created attachment 8489016 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24023
Attachment #8489016 - Flags: review?(m)
Attachment #8489016 - Flags: review?(m) → review+
Blocks: 1070047
(Reporter)

Comment 2

4 years ago
Created attachment 8498745 [details] [review]
Link to PR (rebased)
Attachment #8498745 - Flags: review?(m)
Comment on attachment 8498745 [details] [review]
Link to PR (rebased)

The linter tests fail on your PR, saying "expect" is not defined.
Attachment #8498745 - Flags: review?(m) → review-
(Reporter)

Updated

4 years ago
Attachment #8498745 - Flags: review- → review?(m)
(Reporter)

Comment 4

4 years ago
replace expect to assert
Comment on attachment 8498745 [details] [review]
Link to PR (rebased)

thanks!
Attachment #8498745 - Flags: review?(m) → review+
(Reporter)

Updated

4 years ago
Keywords: checkin-needed
master: https://github.com/mozilla-b2g/gaia/commit/75915628611e946522fe21587fe9eef76793e36c
Status: UNCONFIRMED → RESOLVED
Last Resolved: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S6 (10oct)
This was backed out for not having a bug number in the commit. Commits which do not have bug numbers listed can cause a lot of headache down the road, so please ensure that commits always list the bug number. This is both the job of the author and reviewer to enforce.

I've gone ahead and re-landed this with the proper commit message, containing the bug number.

Backed out in: https://github.com/mozilla-b2g/gaia/commit/d1a29dc02e79dd1cfcd5847b5e8da9c7d65bebd9
Re-landed with the proper commit message: https://github.com/mozilla-b2g/gaia/commit/eb23ec537d5ec9459320a886dd893aca467711c3
You need to log in before you can comment on or make changes to this bug.