1070047 - Upgrade chaijs to a newer version

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TestAgent, defect)

Comment 1

[Julien Wajsberg [:julienw]]

After bug 874510 lands we should add chaijs to package.json (if not already done) and copy it in the update-common Makefile target.

Comment 2

[sv99]

Additional dependencies Bug 1070487, Bug 1069150, Bug 1066988

Comment 3

[Julien Wajsberg [:julienw]]

Next time, you can add the dependencies yourself :) Thanks!

Comment 4

[sv99]

Additional dependencies Bug 1069184, Bug 1070495, Bug 1070845, Bug 1070751, Bug 1070731, Bug 1070681, Bug 1070688 - dependencies i may change only for my bugs! All this bugs have attachment with compatible with both version chaijs tests.

Comment 5

[sv99]

Attachment: Link to PR

Comment 6

[sv99]

Bug 1070845 - [sharedtest] unit test refactoring for new version chai.assert api
Bug 1070751 - [system] unit test refactoring for new version chai.assert api 
Bug 1070731 - [sms] unit test refactoring for new version chai.assert api 
Bug 1070688 - [settings] unit test refactoring for new version chai.assert api 
Bug 1070681 - [communications] unit test refactoring for new version chai.assert api 
Bug 1070495 - [ringtones] unit test refactoring for new version chai.assert api 
Bug 1070487 - [keyboard] unit test refactoring for new version chai.assert api 
Bug 1070006 - [calendar] unit test change chai.assert api in the new version 
Bug 1069184 - [ftu] unittest navigation_test.js incorrect using assert.include for testing existing object

- all incompatibility with new version chaijs fixed

Comment 7

[Julien Wajsberg [:julienw]]

Comment on attachment 8492919 [details] [review]
Link to PR

Can you please request review once all other patches landed? Thanks :)

Comment 8

[sv99]

Request rewiew set. Thanks!

Comment 9

[sv99]

Attachment: Link to PR (rebased)

Comment 10

[Julien Wajsberg [:julienw]]

Comment on attachment 8498752 [details] [review]
Link to PR (rebased)

I think that in the past you produced a patch that upgrades chai.js in the same patch? This is what we want here, IMO...

Comment 11

[sv99]

Right now all test compatible with both version chai

Comment 12

[Julien Wajsberg [:julienw]]

Can you rebase your pull request with latest master, so that we have a Try run?

Comment 13

[Julien Wajsberg [:julienw]]

Also, can you try with latest chai (1.9.2) ? I see you have 1.9.1 in the PR :)

Comment 14

[Julien Wajsberg [:julienw]]

Comment on attachment 8498752 [details] [review]
Link to PR (rebased)

r=me if we have a green run with chai 1.9.2.

let's land this and do some clean up afterwards.

Comment 15

[sv99]

Attachment: Link to PR (rebased) version 1.9.2

Comment 16

[sv99]

PR rebased - ner PR vith version 1.9.2 - CI not started??

Comment 17

[Julien Wajsberg [:julienw]]

master: 6a38f6b7c87d6ba1ccf4ce5a372802bf46d26a67

Comment 18

[Julien Wajsberg [:julienw]]

Thanks so much, it was good work !

Can you file a separate bug to clean up the "pachOldChai" part ?