Closed Bug 1067383 Opened 10 years ago Closed 10 years ago

Properly escape commit messages

Categories

(Tree Management :: Treeherder, defect, P1)

Product:
Tree Management
Component:
Treeherder
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: emorley, Assigned: mdoglio)

References

(
URL
)

Details

Attachments

(1 file)

PR 186 on treeherder-ui
49 bytes, text/x-github-pull-request
camd
: review+
Details | Review
This push: https://treeherder.mozilla.org/ui/#/jobs?repo=mozilla-central&revision=f6a8ea81fa4e Causes requests to: treeherder.mozilla.org/ui/whatever.svg Due to: https://hg.mozilla.org/mozilla-central/rev/ae054f0a9532 ''' (no bug) Drop no-longer-correct "bitmap" qualifier from nsImageFrame header-comment. rs=tn (It's no longer correct because we use nsImageFrame to render e.g. <img src="whatever.svg">, which is not bitmap-flavored at all.) '''
I noticed on IRC Mauro said he was looking into this one, so assigning if that's ok.
Assignee: nobody → mdoglio
URL: https://treeherder.mozilla.org
Status: NEW → ASSIGNED
Attachment #8489997 - Flags: review?(cdawson)
I updated this PR to use _.escape instead of a custom filter.
Commits pushed to master at https://github.com/mozilla/treeherder-ui https://github.com/mozilla/treeherder-ui/commit/9812cd4560bd026a47663aed4527b7f688625225 Bug 1067383 - escape html in commit messages https://github.com/mozilla/treeherder-ui/commit/ab7ef176fee1e62b40dd84d807878fa914564780 Merge pull request #186 from mozilla/bug-1067383-escape-commit-messages Bug 1067383 - escape html in commit messages
Attachment #8489997 - Flags: review?(cdawson) → review+
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Commits pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/04b62e11fa98b0585fec67e7b75b0b9ca1267e8c Bug 1067383 - escape html in commit messages https://github.com/mozilla/treeherder/commit/6d50a859452b807cb857778ebccb5107daac3319 Merge pull request #186 from mozilla/bug-1067383-escape-commit-messages Bug 1067383 - escape html in commit messages
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: