106739 - extend black border of folder pane splitter to include the quick search bar

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[(not reading, please use [e-mail] instead)]

extend black border of folder pane splitter to include the quick search bar

screen shot coming up that compares 3 pane quick search to ab quick search

Comment 1

[(not reading, please use [e-mail] instead)]

Attachment: screen shot

Comment 2

[laurel]

*** Bug 106714 has been marked as a duplicate of this bug. ***

Comment 3

[Ben Ruppel]

Hi, I spent a couple of hours and I got a solution for the modern skin that
looks great.  Unfortunately, I don't know how to use patchmaker yet, so I'll
just give you the code.

The file is mailWindow1.css and it located in \bin\chrome\skin\modern\messenger
Just append the contents of the following quotes to the bottom:
"
/* ..... quicksearch box left border ..... */

#searchBox {
  border-left-style: ridge;
  border-left-width: 2px;
}
"

It might be better with a bottom border, to try it, also inlude this:
  border-bottom-style: ridge;

I am attaching two screenshots.
I had to set the border style to ridge to get it to indent nicely and line up
with the rest of the splitter.  2px cuts the border down just right.

Comment 4

[Ben Ruppel]

Attachment: Picture with code and only left border

Comment 5

[Ben Ruppel]

Attachment: shot with bottom border

Comment 6

[Ben Ruppel]

Attachment: Here is one with a 2px bottom

Comment 7

[Ben Ruppel]

Attachment: Here is one with a solid right border as well. border-right-width: 2px; and style: solid

Comment 8

[Ben Ruppel]

I'm not so sure how that last one will be.  It's a bit too solid.  It looks a 
little bit better when the right style is ridge too, but it's still strong.  
Here's the final code, I'm working on making this into a real diff now.

/* ..... quicksearch box left border ..... */

#searchBox {
  border-left-style: ridge;
  border-bottom-style: ridge;
  border-bottom-width: 2px;
  border-left-width: 2px;
  border-right-style: solid;
  border-right-width: 2px;
}

Comment 9

[Ben Ruppel]

Okay, I can make a diff file now, so I can post that once you decide about the
bottom and left borders.

Comment 10

[Ben Ruppel]

Okay, here is equivalent patch for classic (I don't know why, but it only
accepts the js in this format in the classic mailWindow1.css file.

#searchBox {
  border-left: 2px ridge;
  border-bottom: 1px ridge;
}

screenshot coming up.

Comment 11

[Ben Ruppel]

Actually I'm having trouble getting classic to look right.   I'll get a good
look at it tommorrow.

Comment 12

[Håkan Waara]

I definitely think attachment 55511 [details] looks best, I'll review it when you have a
patch for both classic and modern.

Comment 13

[jglick]

I like attachment 55510 [details], since i don't think the right side border is necessary. 
Nice work!

Comment 14

[Håkan Waara]

I agree with jglick, the right side isn't necessary.

Comment 15

[Ben Ruppel]

Okay, well I'm working on the classic version now, but it's harder to get the
border to look just right.  The rest of the splitter border is made of two
colors, and I can't get those two colors to show up in the right positions.  I
got a border with a color that's between the normal splitter colors, and I think
it looks okay, but not perfect.  Take a look and tell me what you think.

Comment 16

[Ben Ruppel]

Attachment: This is with a solid, imperfect left border

Comment 17

[Håkan Waara]

Looks OK to me.

Comment 18

[Ben Ruppel]

Attachment: Here is classic, with a thinner border that might be acceptable.

Comment 19

[Ben Ruppel]

Attachment: This is the classic quicksearch with a more pannel-ish look

Comment 20

[Ben Ruppel]

Okay, that was my final attachment (I swear!).  This one makes the quicksearch
look more like some other pannels in classic, and it ain't too shabby IMHO.  I
can make the diff files when neccessary, I would just like to know exactly which
attachment picture is the best version.  (modern, I gather, is 55510)

Also, I believe that the classic colors are based on OS settings.  I'm gonna
reboot into win98 and win2k to make sure it looks good to everyone.

Comment 21

[Ben Ruppel]

Attachment: This attachment should take care of modern and classic

Comment 22

[Ben Ruppel]

Note that I have tested this patch on win98, win2k, and winxp and the changes
look good in all.  I have NOT tested on non-win32 platforms.  Also, this is my
first patch and I used patchmaker.

Comment 23

[Navin Gupta]

over to slate who has the fix. 

Comment 24

[Ben Ruppel]

Attachment: Oops, this fixes the bottom border in modern.

Comment 25

[jglick]

Attachment 55550 [details] or attachment 55576 [details] for classic look good.

Comment 26

[andreww]

There are two classic skins - one for windows and one for  mac. is there a 
patch here for mac classic skin yet?

Comment 27

[andreww]

If you need any help with mac  classic please drop me an email.  I'd be 
happy to help out or offer advice.

Comment 28

[Håkan Waara]

Attachment: Valid patch, also affecting mac-classic -- based on slate's fix

Comment 29

[Ben Ruppel]

Attachment: This is a screenshot of what the final patch looks like

Comment 30

[andreww]

Looks ok to me. r=andreww providing the mac patch is included.

Comment 31

[Joe Hewitt (gone)]

Comment on attachment 55641 [details] [diff] [review]
Valid patch, also affecting mac-classic -- based on slate's fix

sr=hewitt

Comment 32

[Håkan Waara]

Fix checked in.  Big thanks to Ben Ruppel for the fix!

Comment 33

[Ben Ruppel]

woohoo, first fix!  I would like to give a shout-out to Gerv, Håkan, and my
homies down in #bugweek.  Thanks, Håkan, for fixing up my patch and getting it
checked in.

Comment 34

[Ben Ruppel]

Just a note, before anyone verifies this they should check out bug 107571.

Comment 35

[laurel]

Fix is evident only on first mail/news launch as further discussed in bug 
107571 (all platforms).
Will verify this when 107571 is resolved.

Comment 36

[Ben Ruppel]

Well well well, after all that, it seems that somebody else has checked in a
patch that changes the way that the splitter is drawn.  Moreover, the new way it
is done is probably much less of a hack than what I had been trying before.  The
fix to this bug should be backed out because 
A) The changes I made do not show up consistently (see bug 107571)
B) When they do show up, there is a double border between the splitter and
quicksearch.

Comment 37

[laurel]

Looks OK to me with jano8 commercial build. Marking verified.