107571 - Fix for bug 106739 not evident in "Modern"

Status: RESOLVED WORKSFORME

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Greg Onufer]

I do not see the improvement shown in the attached images of bug 106739
with the modern theme on Sun/SunOS/mozilla/gtk.  I was building incrementally
so I decided to clobber and perform a fresh build-- no improvement.

Comment 1

[Greg Onufer]

Attachment: Screenshot of relevant mailnews window area near quicksearch entry

Comment 2

[Ben Ruppel]

Okay, i had some trouble getting it to show up too.  It may have to do with the
XUL.mfsl file (not sure about the exension).  This is a bug where the UI is
being precompiled, but this file is not being replaced with new builds.  It
should be fixed in builds coming out soon.  

A) try turning off your XUL cache: preferenced>debug>networking>disable XUL cache
B) while this is turned off, exit mozilla and try deleting your XUL.m??l file in
your profile directory.  Don't worry, this file will be regenerated eventually
when you turn on XUL caching.

Try opening mozilla again.  If it works, you can turn on XUL caching again.  Let
me know about this.

As a side note, this XUL cache problem is causing tons of other bugs for users,
giving people an impression that mozilla is way more broken than it really is. 
I really wish there were a way to announce this fix besides newsgroups.

Comment 3

[Greg Onufer]

That fixed it, now it looks like it's supposed to.  Thanks.

Comment 4

[Ben Ruppel]

Greg, I'm trying to find out other venues for distributing this information, so
that everyone else out there with this kind of problem can find the fix easily.  

Could you tell me a couple of places you have/would have thought to look for a
solution to this problem?  For instance, would you look to Mozillazine, the
newsgroups, mozilla.org?  I want to find a place where this kind of info could go.

Comment 5

[Greg Onufer]

I probably would've found the information in the newsgroups eventually (I check
them in the evenings).  The first place I looked was in the bug report that the
change was integrated under.  Then I checked the bugs submitted today.  The
original bug report should contain this information in addition to anywhere
else.  Fixing the missing cache invalidation would solve the root cause ;-)

Comment 6

[Ben Ruppel]

Hmmm.. okay, well I really wish there was a place to put notes, like a little,
freely editable readme in the nightly dirs.  Anyway, the culprit bug is 106021.

Comment 7

[Christoph]

2001103103/WinMe/Win2000

For me, I can only see this change in Modern with XUL cache off (classic is
still fine).  If I try to turn it on after, it goes away again.  This is even
after fix for 106021 got checked in (late last night).  I'll try a later build
and see if any difference.

Comment 8

[Ben Ruppel]

Yes, I notice this too.  I'm really really really hoping that the problem is
just that the fix isn't in builds yet.

Comment 9

[Greg Onufer]

Me too.  I noticed it this morning when I restarted a build from yesterday
evening and the problem returned.  I have to leave xulcache disabled to
avoid the problem.

I'm pulling the changes from last night and should have a build real soon now.

Comment 10

[Greg Onufer]

A build from literally "just now" still shows the errant behavior if the XUL
cache is enabled.

Comment 11

[Ben Ruppel]

Did you also try deleting your XUL.msfl files at the same time?  Try disabling
XUL cache, turning off mozilla, deleting the file, restarting, then re-enabling
the cache.  If this fails, I'll bring it to someone's attention.  I just know
that sometimes these things (like the fix for 106021) take a while to show up,
even though your build says that it was made after the checkin.

Comment 12

[Greg Onufer]

Yes, all of that.  I made the build, I pulled the sources at 8:51AM PST.
(That's what I meant by "I'm pulling the changes from last night" and
"build from... right now").  Now that was an incremental build to get it
done quicker, I'm starting a clobber build now to test a bit later; maybe
it will behave differently if the dependencies in the Makefiles aren't
100% correct.

Comment 13

[Ben Ruppel]

I'm still having problems with this morning's build. I posted comments to 106021.

Comment 14

[Ben Ruppel]

Okay, as far as I can tell this is more or less related to the XUL caching.  If
I start up mozilla, the first time I enter mailnews the border shows up.  If I
close and reopen mailnews, the border goes away.  If I turn off XUL caching, the
border stays.

Does everyone else see this behavior?  Am I missing any details?

I'm adding hyatt to the cc list on advice from IRC that he might know about this.

Comment 15

[Ben Ruppel]

I'm gonna be out of town until Monday now, so I can't follow up on this right
now.  If you wanna post to the mail-news newsgroup, maybe someone there will
know what's up.

Comment 16

[laurel]

I'm seeing the same behavior reported previously where the border is only 
showing on first launch... happens same on all platforms with Nov7 commercial 
trunk build: win98, mac OS X, linux rh6.2.

Comment 17

[Ben Ruppel]

Based on laurel's comments, can the reporter please change the OS/Platform to
All/All?  I'm trying to get hyatt's attention on IRC now.

Comment 18

[Ben Ruppel]

It seems that another patch has been checked in which changes the way the
splitter is drawn.  Now, when the fix for bug 106739 does show up, it gives a
doubled border.  I have recommended that my fix be backed out, although I still
wish I knew why it showed up only sometimes.

Comment 19

[laurel]

still exists dec14 commercial trunk

Comment 20

[scottputterman]

reassigning to ssu.

Comment 21

[Ben Ruppel]

Can we consider this fixed?  Right now I see the border going all the way up
except for 2 pixels or so.

Comment 22

[Greg Onufer]

I haven't seen this problem in a very long time (SunOS and Linux).

Comment 23

[Greg Onufer]

This has not been reproducible for a very long time.