Closed Bug 1067409 Opened 10 years ago Closed 10 years ago

Check for more cases where we should be filtering by |active_status='active'|

Categories

(Tree Management :: Treeherder, defect, P3)

Product:
Tree Management
Component:
Treeherder
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: emorley, Assigned: emorley)

References

Details

Attachments

(1 file)

Filter on repository active_status in more cases
54 bytes, text/x-github-pull-request
mdoglio
: review+
Details | Review
In bug 1065659 there was already once instance of us using the full repos list rather than the active repos only, when we shouldn't have done. A quick search shows there may be some more cases, eg in calculate-eta.
git grep can be really helpful for this kind of task.
Assignee: nobody → emorley
Status: NEW → ASSIGNED
Summary: Check for uses of Repository.objects.all() that should be Repository.objects.filter(active_status='active') → Check for more cases where we should be filtering by |active_status='active'|
Comment on attachment 8550714 [details] [review] Filter on repository active_status in more cases Found these two, think that's it.
Attachment #8550714 - Flags: review?(mdoglio)
Attachment #8550714 - Flags: review?(mdoglio) → review+
Commit pushed to master at https://github.com/mozilla/treeherder-service https://github.com/mozilla/treeherder-service/commit/96d5d4255457c2ce7b052432aa591b2e419cad93 Bug 1067409 - Filter on repository active_status in more cases We should only include active repositories when performing init_datasources or calculating job etas.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Depends on: 1134804
No longer depends on: 1134804
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: