ContentChild::QuickExit() should not gently fail in debug builds

NEW
Unassigned

Status

()

Core
DOM: Content Processes
4 years ago
4 years ago

People

(Reporter: mccr8, Unassigned)

Tracking

(Depends on: 4 bugs)

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

4 years ago
QuickExit() is used in a bunch of places.  Only one of those places, the early exit in non-debug builds, is normal.  The rest of the places are places where we've gotten an error we've decided is so bad we need to immediately kill the process.  The problem is that because QuickExit() is very gentle, only doing an NS_WARNING() followed by an _exit(0), there's no noticeable indication of this on automation, so there are a ton of reasons we QuickExit() in a normal run.

Eventually, I'd like to get leak log checking re-enabled, so that we error out if we fail to produce one, which will notice these failures, but it seems like we should actually fail in a way that will give us information about what went wrong, with an assert plus an exit(-1) or something.
(Reporter)

Updated

4 years ago
Blocks: 1051230
(Reporter)

Updated

4 years ago
Depends on: 1080017
(Reporter)

Updated

4 years ago
(Reporter)

Comment 1

4 years ago
I'm pushing ahead with an alternate plan to get leak checking working, bug 1091766, but this would still be good to do to be able to detect places that may be behaving badly when they run after shutdown.
No longer blocks: 1051230
You need to log in before you can comment on or make changes to this bug.