Closed Bug 1091766 Opened 7 years ago Closed 7 years ago

Drop messages more gently in ContentChild

Categories

(Core :: DOM: Content Processes, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla38

People

(Reporter: mccr8, Assigned: mccr8)

References

Details

(Whiteboard: [MemShrink:P1])

Attachments

(1 file)

Currently, a child process quietly exits when a message to or from it gets dropped. This causes us to not run the rest of shut down, including leak logs. Instead of doing this, I would like to just soldier on. The message is still not going to be sent.

Bug 1067633 is on file to track some of the places we send messages too late.
This appears to be causing a failure in B2G ICS Emulator opt M5 in PNeckoChild::SendPCookieServiceConstructor:

    bool __sendok = (mChannel)->Send(__msg);
    if ((!(__sendok))) {
        NS_RUNTIMEABORT("constructor for actor failed"); <-- failure here
        return nullptr;
    }

I guess before we'd fail to Send(), but just quietly exit(0) there, whereas now we return and NS_RUNTIMEABORT().
Attachment #8514566 - Flags: review?(bent.mozilla)
Depends on: 1092220
Whiteboard: [MemShrink]
Whiteboard: [MemShrink] → [MemShrink:P1]
Depends on: 1100695
There's a lingering test issue or two, as indicated in the blocking bugs, but I think that's just weird tests, so this seems ready for review.
  https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=4ac4827a2b0d
Attachment #8514566 - Flags: review?(bent.mozilla)
Comment on attachment 8514566 [details] [diff] [review]
Don't exit(0) when a message is dropped in the child process.

Review of attachment 8514566 [details] [diff] [review]:
-----------------------------------------------------------------

Let's keep a warning at least?
Attachment #8514566 - Flags: review?(bent.mozilla) → review+
(In reply to ben turner [:bent] (use the needinfo? flag!) from comm
> Let's keep a warning at least?

We actually print out a message higher up the stack, but yeah I can add in something here, in case something else calls into this.
Depends on: 1103107
Depends on: 1103279
Blocks: 1095754
Depends on: 1104999
No longer blocks: 1095754
Bug 1103036 seems like a better approach.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
This papers over some shutdown weirdness, even with bug 1103036, so I'm going to go ahead and land it, hopefully today.
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
https://hg.mozilla.org/mozilla-central/rev/e097e82fa29b
Status: REOPENED → RESOLVED
Closed: 7 years ago7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.