1067810 - Review history page displays the wrong duration

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Extensions, defect)

Description

[Ed Morley [:emorley]]

eg on:
https://bugzilla.mozilla.org/page.cgi?id=review_history.html&requestee=emorley%40mozilla.com

The entry for bug 969123 says 7 hours, whereas in the bug, the review+ was 3 minutes after the review request.

Comment 1

[Ed Morley [:emorley]]

And bug 994359 was listed as having duration 8 hours, but in the bug shows 27 mins.

Comment 2

[Ed Morley [:emorley]]

This bug is present after the latest landing (not sure if the other bug was supposed to fix this).

Comment 3

[Dylan Hardison [:dylan] (he/him)]

This is caused by bug 1070317. New flag activity records will have the correct date (because we bypass $flag->modification_date) but the historical data is wrong.

Comment 4

[Dylan Hardison [:dylan] (he/him)]

Attachment: post-data-fixup.png

After correcting for the timezone error, I am able to find the timestamps for all canceled flags, except in the case where a user has been renamed. Screenshot demonstrating this for Ed Morley's review history.

Comment 5

[Dylan Hardison [:dylan] (he/him)]

Created tracking bug for this. We're going to have to deal with the incorrect data for now. As a fix, I think we can filter out anything before 2014-09-23. We'll keep the data, and maybe we'll come up with a clever solution.

Comment 6

[Dylan Hardison [:dylan] (he/him)]

Attachment: bug-1067810-v1.patch

As we cannot fix the data right now, we should hide it. This patch hides all review history that happened before this week's push.

Comment 7

[David Lawrence [:dkl]]

Comment on attachment 8496216 [details] [diff] [review]
bug-1067810-v1.patch

Review of attachment 8496216 [details] [diff] [review]:
-----------------------------------------------------------------

r=dkl

Comment 8

[Dylan Hardison [:dylan] (he/him)]

To ssh://[e-mail]/webtools/bmo/bugzilla.git
   84b390d..977ba8b  master -> master