1067969 - Thunderbird starts with blank panels

Status: VERIFIED DUPLICATE of bug 1054357

(Thunderbird :: General, defect)

Description

[Bob Clary [:bc] (inactive)]

With today's update, Thunderbird fails to start properly. I also have lightning installed but this reproduces with a fresh profile. This also reproduces after deleting the installation directory and installing a fresh copy of Thunderbird.

The only error message in the console is:

Failed to load native module at path '/.../thunderbird/components/libxpcomsample.so': (80004005) /home/bclary/bin/thunderbird-nightly/thunderbird/components/libxpcomsample.so: cannot open shared object file: No such file or directory


in thunderbird/components (sisyphus-dev)
$ ls
components.manifest  libdbusservice.so  libmozgnome.so

$ cat components.manifest 
binary-component libdbusservice.so
binary-component libmozgnome.so
binary-component libxpcomsample.so

Comment 1

[Bob Clary [:bc] (inactive)]

fwiw, I removed libxpcomsample.so from the components.manifest and still get the blank panels.

Comment 2

[Bob Clary [:bc] (inactive)]

I presume this is due to bug 1001090 but don't have any concrete proof.

Comment 3

[Alice0775 White]

Regression window
Good:
https://hg.mozilla.org/mozilla-central/rev/989c1c75889c
https://hg.mozilla.org/comm-central/rev/c4935789ba20
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:35.0) Gecko/20100101 Thunderbird/35.0a1 ID:20140915114133
Bad:
https://hg.mozilla.org/mozilla-central/rev/3b7921328fc1
https://hg.mozilla.org/comm-central/rev/b64e243a8401
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:35.0) Gecko/20100101 Thunderbird/35.0a1 ID:20140915114133
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=989c1c75889c&tochange=3b7921328fc1
http://hg.mozilla.org/comm-central/pushloghtml?fromchange=c4935789ba20&tochange=b64e243a8401

Comment 4

[Magnus Melin [:mkmelin]]

There's a bunch of errors in the error console

Timestamp: 16.09.2014 21.38.26
Error: TypeError: redeclaration of variable iter
Source File: chrome://messenger/content/folderPane.js
Line: 2483, Column: 8
Source Code:
    let iter = fixIterator(folder.messages); 


Timestamp: 16.09.2014 21.38.26
Error: TypeError: redeclaration of variable notification
Source File: chrome://messenger/content/plugins.js
Line: 697

Timestamp: 16.09.2014 21.38.26
Error: TypeError: redeclaration of variable tab
Source File: chrome://messenger/content/tabmail.xml
Line: 811, Column: 16
Source Code:
            let tab = JSON.parse(JSON.stringify(tab)); 

Timestamp: 16.09.2014 21.38.27
Error: TypeError: redeclaration of variable allFolders
Source File: chrome://messenger/content/folderWidgets.xml
Line: 569, Column: 14
Source Code:
          let allFolders = allFolders.filter(function (f) f.canFileMessage

Comment 5

[Jeff Walden [:Waldo]]

Shu posted messages to m.d.platform with some scripts capable of detecting all these syntax errors and pointing them out all at once, versus fixing and retesting manually.  Probably worth a look at that, first of all.

Comment 6

[Magnus Melin [:mkmelin]]

Attachment: bug1067969_tb_blank_let_derecl.patch

This should be it, at least it works fine locally. (Didn't look at a script yet.)

Whoever gets to this first.

Comment 8

[Kent James (:rkent)]

Comment on attachment 8490285 [details] [diff] [review]
bug1067969_tb_blank_let_derecl.patch

Review of attachment 8490285 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with nit fixed.

::: mail/base/content/plugins.js
@@ +711,5 @@
>      function showNotificationBar(pluginDumpID, browserDumpID) {
>        // If there's already an existing notification bar, don't do anything.
>        let messengerBundle = document.getElementById("bundle_messenger");
> +      let exisitingNotification = notificationBox.getNotificationWithValue("plugin-crashed");
> +      if (exisitingNotification)

Nit: please spell this correctly as existingNotification (2 lines)

Comment 9

[Kent James (:rkent)]

There is a more extensive patch for this in bug 1054357 that includes these fixes and more. Magnus, could you take a look at that?

Comment 10

[Mark Banner (:standard8)]

Comment on attachment 8490285 [details] [diff] [review]
bug1067969_tb_blank_let_derecl.patch

The patches in bug 1054357 are more extensive, so I've taken them.