1068055 - [Gingerbread] VP9/WEBM video artifacts, only plays on half screen

Status: RESOLVED INCOMPLETE

(Core :: Audio/Video: Playback, defect)

Description

[u421692]

Attachment: screenshot

Environment:
Device: HTC Desire HD(Android 2.3.5)
Build: Firefox 33 Beta 6

Steps to reproduce:
1. http://people.mozilla.org/~atrain/mobile/tests/media.html
2. Play first video

Expected result:
Video plays without any issues

Actual result:
VP9/WEBM has video artifacts, only plays on half screen(see attached screenshot)

Comment 1

[Kevin Brosnan [Ex-Mozilla]]

Mihai is this a regression?

Comment 2

[Aaron Train [:aaronmt]]

Can you also capture OMX related output in console and attach it here? I also searched through history and see a similar bug 993432 filed against the HTC Desire HD

Comment 3

[u421692]

Logs: https://pastebin.mozilla.org/6526848

2014-05-22 - good build
2014-05-23 - bad build
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=b40296602083&tochange=e9b2b72f4e6c

Can only guess that this regressed from Bug 908503 - Update demuxer in MP4Reader to be usable for <video>

Comment 4

[Kevin Brosnan [Ex-Mozilla]]

[Tracking Requested - why for this release]: Regression in Fx32

Comment 5

[Sylvestre Ledru [:Sylvestre]]

Anthony, does that ring a bell? Thanks

Comment 6

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

That commit imports some android code which appears to be interfering with VP9 playback on Android itself. The C++ code is in a separate namespace but the C code is not. I've spent some time working on it but haven't found a sensible solution yet.

Comment 7

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Not me this time. Looks like the culprit is:

78bc7d04bac9 Andreas Gal — Bug 1012407 - Part 6: Eliminate VBO use and DrawQuads and manually draw no-repeat quads (r=Bas)

http://hg.mozilla.org/mozilla-central/rev/78bc7d04bac9

Comment 8

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Milan - this looks like a graphics issue introduced in Andreas' patch. Can you find someone to look into it?

Comment 9

[Milan Sreckovic [:milan] (needinfo for best results)]

Will take care of it - Anthony, since you can reproduce this - any assertions when running a debug build?

Comment 10

[Milan Sreckovic [:milan] (needinfo for best results)]

(In reply to Anthony Jones (:kentuckyfriedtakahe, :k17e) from comment #7)
> Not me this time. Looks like the culprit is:
> 
> 78bc7d04bac9 Andreas Gal — Bug 1012407 - Part 6: Eliminate VBO use and
> DrawQuads and manually draw no-repeat quads (r=Bas)
> 
> http://hg.mozilla.org/mozilla-central/rev/78bc7d04bac9

Even after the "fix for part 6" in https://hg.mozilla.org/mozilla-central/rev/5b6ae4c0a754 ?

Comment 11

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

(In reply to Milan Sreckovic [:milan] from comment #9)
> Will take care of it - Anthony, since you can reproduce this - any
> assertions when running a debug build?

I'll check that. You should be able to repro it on any Gingerbread phone, or at least I could on the first one I tried.

I checked nightly, beta and a lot of builds in the regression range. I'll try that specific commit.

Comment 12

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

It is still broken on 5b6ae4c0a754.

Comment 13

[Milan Sreckovic [:milan] (needinfo for best results)]

"Any Gingerbread phone" isn't easy to find these days.  I found Samsung GT-S5670L, with 2.3.4 on it, but Nightly runs fine, shows that video without scaling it.  Also no luck reproducing on Samsung S, with 2.3.6 on it with the Nightly.

Comment 14

[Milan Sreckovic [:milan] (needinfo for best results)]

Trying to get the data remotely - can somebody that can reproduce this try setting preference layout.css.devPixelsPerPx to 1 and see if it affects this bug?

Comment 15

[Milan Sreckovic [:milan] (needinfo for best results)]

I imagine we're tickling a driver bug - the phone Mihai listed is Adreno GPU, the two that I tried with are PowerVR and VideoCore.  Anthony, what's the device you're testing with?

Comment 16

[Aaron Train [:aaronmt]]

I have a Nexus S on 2.3.4 and am unable to reproduce this.

Comment 17

[u421692]

(In reply to Milan Sreckovic [:milan] from comment #14)
> Trying to get the data remotely - can somebody that can reproduce this try
> setting preference layout.css.devPixelsPerPx to 1 and see if it affects this
> bug?

I was able to reproduce this issue on a HTC Desire S (Android 2.3.3), setting preference layout.css.devPixelsPerPx to 1 did not make any difference.

Comment 18

[Milan Sreckovic [:milan] (needinfo for best results)]

(In reply to Mihai Pop from comment #17)
> I was able to reproduce this issue on a HTC Desire S (Android 2.3.3)...

Makes sense, also Adreno.

Comment 19

[Sylvestre Ledru [:Sylvestre]]

It does not seem we are going to have a patch for 33. wontfix then!

Comment 20

[Milan Sreckovic [:milan] (needinfo for best results)]

(In reply to Sylvestre Ledru [:sylvestre] from comment #19)
> It does not seem we are going to have a patch for 33. wontfix then!

Right, probably not - Anthony is going to bring along the phone next week, so we can take a look at it.

Comment 21

[Sylvestre Ledru [:Sylvestre]]

Added to the 33 release notes (known issues)

Comment 22

[Lawrence Mandel [:lmandel] (use needinfo)]

Milan - Were you able to debug with Anthony this week?

Comment 23

[Milan Sreckovic [:milan] (needinfo for best results)]

I have the phone in my hand now, but no, haven't had a chance to actually look at it.  Next week is a short week, but should be able to take care of it.

Comment 24

[Lawrence Mandel [:lmandel] (use needinfo)]

Milan - As you're currently working on this one, I'm assigning to you. (Like to know who's tracking beta bugs.)

Comment 26

[Lawrence Mandel [:lmandel] (use needinfo)]

We've been focused on some higher priority issues and so are going to have to ship this again in 34. We can try for a fix again in 35.

Comment 27

[Lukas Blakk [:lsblakk] use ?needinfo]

Re-ping Milan for this one - we've shipped a couple of releases already with this regression, is this on your radar still and can we expect any resolution in the next week to get onto beta?

Comment 28

[Lukas Blakk [:lsblakk] use ?needinfo]

We're out of time for 35, but tracking once more for 36 to get an answer to comment 27 and see if we'll get any traction here.

Comment 29

[Milan Sreckovic [:milan] (needinfo for best results)]

Yes, let's try one more cycle.

Comment 30

[Sylvestre Ledru [:Sylvestre]]

We have this bug since 32 and still no activity, I don't see the point of tracking it for much longer.

Comment 31

[u597032]

Gingerbread is no longer supported.