Closed
Bug 1068144
Opened 10 years ago
Closed 10 years ago
Expose allocation time stamps in the memory actor
Categories
(DevTools :: Memory, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 36
People
(Reporter: fitzgen, Assigned: fitzgen)
References
Details
Attachments
(1 file, 1 obsolete file)
|
7.76 KB,
patch
|
fitzgen
:
review+
|
Details | Diff | Splinter Review |
Bug 1066313 added allocations recording to the memory actor, bug 1067491 extends the data source with time stamps for allocations. We should update the actor to expose the time stamps as well.
|
Assignee | |
Comment 1•10 years ago
|
||
Decided to go with a parallel array for backwards compat with the protocol + less allocations overhead in the server.
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=b9bd5662afab
Attachment #8512279 -
Flags: review?(jryans)
Comment on attachment 8512279 [details] [diff] [review]
allocation-time-stamps.patch
Review of attachment 8512279 [details] [diff] [review]:
-----------------------------------------------------------------
There aren't any active consumers that I can see... so don't think backward compat really matter here.
So, it's just overhead to be worried about. I assume you convinced yourself it's worth this design! :)
Attachment #8512279 -
Flags: review?(jryans) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
(In reply to J. Ryan Stinnett [:jryans] from comment #2)
> Comment on attachment 8512279 [details] [diff] [review]
> allocation-time-stamps.patch
>
> Review of attachment 8512279 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> There aren't any active consumers that I can see... so don't think backward
> compat really matter here.
Potentially it lets the frontend we build Just Work with older versions of firefox. But yeah, not a super heavyweight argument.
|
|
Assignee | |
Comment 4•10 years ago
|
||
Based on the try push, looks like I need to make the test less strict regarding what "about 1 ms" actually is.
|
|
Assignee | |
Comment 5•10 years ago
|
||
Carrying over r+.
New try push: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=388b68dad5d3
Attachment #8512279 -
Attachment is obsolete: true
Attachment #8512893 -
Flags: review+
|
|
Assignee | |
Updated•10 years ago
|
Keywords: checkin-needed
|
||
Comment 6•10 years ago
|
||
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
|
||
Comment 7•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 36
|
||
Updated•7 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•