1068171 - Give the memory actor/client the ability to control the allocation sampling probability

Status: RESOLVED FIXED

(DevTools :: Memory, defect)

Description

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

In `startRecordingAllocations` we should accept a config object with an `allocationSamplingProbability` property to control how often we sample allocations.

(Config object so its future extensible.)

Comment 1

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: memory-actors-probability.patch

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8491153 [details] [diff] [review]
memory-actors-probability.patch

Review of attachment 8491153 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/devtools/server/actors/memory.js
@@ +180,2 @@
>      this._initFrames();
> +    dbg.memory.allocationSamplingProbability = options.probability != null

Seems like you need "this.dbg...", right?

Comment 3

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

... yes >.<

Comment 4

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: memory-actors-probability.patch

https://tbpl.mozilla.org/?tree=Try&rev=1c9e5aeeb555

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/903a2f03336f

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/903a2f03336f