Closed
Bug 1068171
Opened 8 years ago
Closed 8 years ago
Give the memory actor/client the ability to control the allocation sampling probability
Categories
(DevTools :: Memory, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 35
People
(Reporter: fitzgen, Assigned: fitzgen)
References
Details
Attachments
(1 file, 1 obsolete file)
6.64 KB,
patch
|
jryans
:
review+
|
Details | Diff | Splinter Review |
In `startRecordingAllocations` we should accept a config object with an `allocationSamplingProbability` property to control how often we sample allocations. (Config object so its future extensible.)
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8491153 -
Flags: review?(jryans)
Comment on attachment 8491153 [details] [diff] [review] memory-actors-probability.patch Review of attachment 8491153 [details] [diff] [review]: ----------------------------------------------------------------- ::: toolkit/devtools/server/actors/memory.js @@ +180,2 @@ > this._initFrames(); > + dbg.memory.allocationSamplingProbability = options.probability != null Seems like you need "this.dbg...", right?
Attachment #8491153 -
Flags: review?(jryans)
Assignee | ||
Comment 3•8 years ago
|
||
... yes >.<
Assignee | ||
Comment 4•8 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=1c9e5aeeb555
Attachment #8491153 -
Attachment is obsolete: true
Attachment #8493950 -
Flags: review?(jryans)
Attachment #8493950 -
Flags: review?(jryans) → review+
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Comment 5•8 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/903a2f03336f
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
Comment 6•8 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/903a2f03336f
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 35
Updated•4 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•