Closed Bug 1068171 Opened 6 years ago Closed 6 years ago

Give the memory actor/client the ability to control the allocation sampling probability

Categories

(DevTools :: Memory, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 35

People

(Reporter: fitzgen, Assigned: fitzgen)

References

Details

Attachments

(1 file, 1 obsolete file)

In `startRecordingAllocations` we should accept a config object with an `allocationSamplingProbability` property to control how often we sample allocations.

(Config object so its future extensible.)
Attached patch memory-actors-probability.patch (obsolete) — Splinter Review
Attachment #8491153 - Flags: review?(jryans)
Depends on: 1056373
Comment on attachment 8491153 [details] [diff] [review]
memory-actors-probability.patch

Review of attachment 8491153 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/devtools/server/actors/memory.js
@@ +180,2 @@
>      this._initFrames();
> +    dbg.memory.allocationSamplingProbability = options.probability != null

Seems like you need "this.dbg...", right?
Attachment #8491153 - Flags: review?(jryans)
... yes >.<
https://hg.mozilla.org/mozilla-central/rev/903a2f03336f
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 35
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.