1068326 - Bogus threading assertion in blob code

Status: RESOLVED WORKSFORME

(Core :: DOM: Content Processes, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch

This is just wrong.  The fact that we don't have any failing tests is a bit disconcerting ...

Comment 1

[Daniel Holbert [:dholbert]]

(While you're at it, maybe add a MOZ_OVERRIDE annotation to the BlockAndGetInternalStream() signature here? This is an implementation of a method that's declared in a superclass (IPrivateRemoteInputStream), so it should have the annotation.)

Comment 3

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 8490364 [details] [diff] [review]
Patch

Review of attachment 8490364 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 4

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch

For checkin.

Comment 5

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Bug 994190 was backed out so this is technically WFM.

However, I'm going to land this on jamun, and then it will land again once bug 994190 is fixed.