1068479 - Copy paste toolbox has no hit state

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

STR:

1. Long press on a word and wait for the copy-paste toolbox to show
2. Tap "copy"

Expected:

1. Some kind of indication to tell the word is indeed copied

Actual:

1. The toolbox simply disappears w/o any visual indication on whether or not I indeed hit the button or I accidentally hit the surrounding space.

Comment 1

[Omega Feng [:Omega] [:馮於懋]]

After discussion with George, we decided to do it this way.
The current implementation does the action when user finger-presses on a button, so there is no state changes of the button. First, we should fix this problem by doing the action when user finger-releases on the button.
Then, when user taps (presses and then releases) a button, the button should stay at pressed state, and then fades out transition with the whole bubble, so that user can tell which button is tapped or he just taps outside of the bubble.

Comment 2

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to master

Comment 3

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to master

Hi Carol,
could I have your ui-review on this patch? Thanks.

Comment 4

[Carol Huang [:Carol]]

Comment on attachment 8498579 [details] [review]
PR to master

Looks great! thanks George!

Comment 5

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8498579 [details] [review]
PR to master

Hi Alive,
could you kindly review this patch?

Comment 6

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8498579 [details] [review]
PR to master

Tim is looking, bypassing

Comment 7

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8498579 [details] [review]
PR to master

No, I was merely making some drive-by comments. I can't review this since I don't understand the code fully.

Comment 8

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8498579 [details] [review]
PR to master

Please see comments in github.

Comment 9

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8498579 [details] [review]
PR to master

Hi Alive,
I separate elementEventHandler and transitionState out of original code for easily understanding.
could you review again? Thanks.

Comment 10

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8498579 [details] [review]
PR to master

r+ with nits

Comment 11

[(Inactive after June) George Duan [:gduan] [:喬智]]

Thanks,
master: https://github.com/mozilla-b2g/gaia/commit/89445fa67086e0fca68ce11cd6d89b72f0eea675