Closed Bug 1068479 Opened 8 years ago Closed 8 years ago

Copy paste toolbox has no hit state

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: timdream, Assigned: gduan)

References

Details

(Whiteboard: [FT:System-Platform])

Attachments

(1 file, 1 obsolete file)

STR:

1. Long press on a word and wait for the copy-paste toolbox to show
2. Tap "copy"

Expected:

1. Some kind of indication to tell the word is indeed copied

Actual:

1. The toolbox simply disappears w/o any visual indication on whether or not I indeed hit the button or I accidentally hit the surrounding space.
Flags: needinfo?(ofeng)
After discussion with George, we decided to do it this way.
The current implementation does the action when user finger-presses on a button, so there is no state changes of the button. First, we should fix this problem by doing the action when user finger-releases on the button.
Then, when user taps (presses and then releases) a button, the button should stay at pressed state, and then fades out transition with the whole bubble, so that user can tell which button is tapped or he just taps outside of the bubble.
Flags: needinfo?(ofeng) → needinfo?(gduan)
Assignee: nobody → gduan
Flags: needinfo?(gduan)
Attached file PR to master (obsolete) —
Attached file PR to master
Hi Carol,
could I have your ui-review on this patch? Thanks.
Attachment #8497657 - Attachment is obsolete: true
Attachment #8498579 - Flags: ui-review?(chuang)
Comment on attachment 8498579 [details] [review]
PR to master

Looks great! thanks George!
Attachment #8498579 - Flags: ui-review?(chuang) → ui-review+
Comment on attachment 8498579 [details] [review]
PR to master

Hi Alive,
could you kindly review this patch?
Attachment #8498579 - Flags: review?(alive)
Comment on attachment 8498579 [details] [review]
PR to master

Tim is looking, bypassing
Attachment #8498579 - Flags: review?(alive) → review?(timdream)
Comment on attachment 8498579 [details] [review]
PR to master

No, I was merely making some drive-by comments. I can't review this since I don't understand the code fully.
Attachment #8498579 - Flags: review?(timdream) → review?(alive)
Comment on attachment 8498579 [details] [review]
PR to master

Please see comments in github.
Attachment #8498579 - Flags: review?(alive)
Comment on attachment 8498579 [details] [review]
PR to master

Hi Alive,
I separate elementEventHandler and transitionState out of original code for easily understanding.
could you review again? Thanks.
Attachment #8498579 - Flags: review?(alive)
Comment on attachment 8498579 [details] [review]
PR to master

r+ with nits
Attachment #8498579 - Flags: review?(alive) → review+
Thanks,
master: https://github.com/mozilla-b2g/gaia/commit/89445fa67086e0fca68ce11cd6d89b72f0eea675
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.