Closed
Bug 1068532
Opened 10 years ago
Closed 10 years ago
Keyboard shortcuts aren't ignored if pressed with a modifier (eg ctrl)
Categories
(Tree Management :: Treeherder, defect, P3)
Tree Management
Treeherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: emorley, Assigned: jfrench)
References
()
Details
Attachments
(1 file)
I frequently use the web console. The shortcut for opening it is ctrl+shift+k.
If you perform that key combination whilst on a treeherder tab, treeherder responses as though you have pressed just the 'k' key.
ie: Treeherder should treat "ctrl + <key>" separately from just "<key>".
Reporter | ||
Updated•10 years ago
|
Summary: Keyboard shortcuts don't observe key modifiers (eg ctrl) → Keyboard shortcuts aren't ignored if pressed with a modifier (eg ctrl)
Assignee | ||
Comment 2•10 years ago
|
||
I have this working locally, but want to check a few more key scenarios before assigning myself.
Assignee | ||
Updated•10 years ago
|
Assignee | ||
Comment 3•10 years ago
|
||
Please see the above PR for review and status.
Reporter | ||
Updated•10 years ago
|
Attachment #8495373 -
Flags: review?(mdoglio)
Updated•10 years ago
|
Attachment #8495373 -
Flags: review?(mdoglio) → review+
Comment 4•10 years ago
|
||
Commits pushed to master at https://github.com/mozilla/treeherder-ui
https://github.com/mozilla/treeherder-ui/commit/cc9c7415b8c20fa942a1e50c9dc19ddac54257cd
Bug 1068532 - Ignore keyboard shortcuts if modifiers used
https://github.com/mozilla/treeherder-ui/commit/5c8afa84661f8c00a3ccc98d5c2c426dca1013a2
Merge pull request #206 from tojonmz/modifier-key-events
Bug 1068532 - Ignore keyboard shortcuts if modifiers used
Assignee | ||
Comment 5•10 years ago
|
||
Verified fixed and working correctly on production.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•10 years ago
|
No longer blocks: treeherder-dev-transition
Reporter | ||
Comment 6•10 years ago
|
||
This was a regression, so should block the bug.
Thank you for fixing this :-)
Blocks: treeherder-dev-transition
Assignee | ||
Comment 7•10 years ago
|
||
Ah, got it. Thanks Ed.
Comment 8•9 years ago
|
||
Commits pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/c0c4b5461cffdf1a3f305c95b602fe621c36b62c
Bug 1068532 - Ignore keyboard shortcuts if modifiers used
https://github.com/mozilla/treeherder/commit/5a9ce2556494f4994558a398ea98eede2a504756
Merge pull request #206 from tojonmz/modifier-key-events
Bug 1068532 - Ignore keyboard shortcuts if modifiers used
You need to log in
before you can comment on or make changes to this bug.
Description
•