1068594 - UI glitches on the 'Accept' button in the incoming call window

Status: RESOLVED WONTFIX

(Hello (Loop) :: Client, defect, P4)

Description

[Paul Silaghi, QA [:pauly]]

Attachment: loop client incoming call.png

Fallout from bug 990678

Comment 1

[:shell escalante]

sharper SVG icons are attached to https://bugzilla.mozilla.org/show_bug.cgi?id=1016087

Comment 2

[Daniel Holbert [:dholbert]]

(Same issues on Linux Nightly, FWIW. There's no space between "Accept" & the video icon, and the mic icon looks blurry. --> setting OS to "all")

Comment 3

[Andrei Oprea [:andreio]]

Attachment: Fix UI glitches in loop panel answer button

Comment 4

[Andrei Oprea [:andreio]]

Added a css helper class to fix padding between text & icon.
Dropped the non retina icons because non-retina icons apparently weren't good enough.
Did not switch to svg icons because as discussed offline with Niko there will be a bug to migrate all icons.

Comment 5

[Andrei Oprea [:andreio]]

Attachment: Fix UI glitches in loop panel answer button

Comment 6

[Maire Reavy [:mreavy]]

Moving P2->P3 (P3 is a "normal" bug that we want fixed for Fx36.)

Comment 7

[Mark Banner (:standard8)]

Andrei, can you remember why you never requested review on this?

Comment 8

[Mark Banner (:standard8)]

NiKo: could you look at updating this/checking if its ready for review?

Comment 9

[Andrei Oprea [:andreio]]

I should have another look at this since the patch is old.

Comment 10

[Andrei Oprea [:andreio]]

(In reply to Mark Banner (:standard8) from comment #7)
> Andrei, can you remember why you never requested review on this?

I made the patch during the Portland work week, thought I could discuss it in person but the schedule was a bit crazy

Comment 11

[Mark Banner (:standard8)]

We are currently reworking the Loop "user journey" (bug 1209713) and as part of this direct calls and contacts are being removed. Therefore closing direct call related bugs as wontfix.

Tracking id: directcallclosing