Closed
Bug 1068739
Opened 9 years ago
Closed 9 years ago
Record position of search suggestion that was tapped in telemetry
Categories
(Firefox for Android Graveyard :: Search Activity, defect)
Tracking
(firefox36 verified)
VERIFIED
FIXED
Firefox 35
Tracking | Status | |
---|---|---|
firefox36 | --- | verified |
People
(Reporter: Margaret, Assigned: Margaret)
References
Details
(Whiteboard: shovel-ready)
Attachments
(1 file)
1.64 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
Here's the code we'd need to change: http://mxr.mozilla.org/mozilla-central/source/mobile/android/search/java/org/mozilla/search/autocomplete/SuggestionsFragment.java#110
Assignee | ||
Comment 1•9 years ago
|
||
I say that we should just replace the "suggest" extra with the position, since it's redundant with the SUGGESTION method. mfinkle, what do you think?
Flags: needinfo?(mark.finkle)
Comment 2•9 years ago
|
||
(In reply to :Margaret Leibovic from comment #1) > I say that we should just replace the "suggest" extra with the position, > since it's redundant with the SUGGESTION method. > > mfinkle, what do you think? Agreed
Flags: needinfo?(mark.finkle)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → margaret.leibovic
Assignee | ||
Comment 3•9 years ago
|
||
Attachment #8499579 -
Flags: review?(mark.finkle)
Updated•9 years ago
|
Attachment #8499579 -
Flags: review?(mark.finkle) → review+
Assignee | ||
Comment 4•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/1cacd42c198b
Comment 5•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/1cacd42c198b
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
Comment 6•9 years ago
|
||
Verified as fixed in build 36.0a1 2014-11-17; Device: Asus Transformer Tab (Android 4.0.3).
Status: RESOLVED → VERIFIED
status-firefox36:
--- → verified
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•