Pocket add-on from AMO no longer works, after bug 1001090 made JS engine stricter about variable redeclaration

RESOLVED FIXED

Status

Tech Evangelism
Add-ons
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: dholbert, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

3 years ago
STR:
 1. Install "Pocket" extension, from https://addons.mozilla.org/en-US/firefox/addon/read-it-later/
 2. Restart Firefox to complete installation
 3. Inspect right edge of URL bar.

EXPECTED RESULTS:
 Pocket icon should be present at right end of URL bar

ACTUAL RESULTS:
 No Pocket icon shows up.
 Also, Browser Console has this error:
  TypeError: redeclaration of variable item       RIL.js:655

Last good revision: bf5fcc0c4b27 (2014-09-15)
First bad revision: 55b46de164d8 (2014-09-16)
Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=bf5fcc0c4b27&tochange=55b46de164d8

Seems to be an expected result of the change in bug 1001090 (which makes "let" redeclarations invalid), and the add-on needs updating to remain compatible.

(See also dev.platform post about this change here: https://groups.google.com/forum/#!topic/mozilla.dev.platform/tezdW299Zds )
(Reporter)

Comment 1

3 years ago
(NOTE: This is about the "legacy" Pocket extension, hosted on AMO. They also have a newer SocialAPI-based extension here -- https://getpocket.com/firefox/ -- that one still seems to work [adding an icon to your toolbar instead of the URLbar], though I personally prefer the older extension, which is why I ran up against & reported this bug.)
(Reporter)

Updated

3 years ago
See Also: → bug 1058824
(Reporter)

Updated

3 years ago
Summary: Pocket add-on from AMO no longer works, after bug 1001090 → Pocket add-on from AMO no longer works, after bug 1001090 made JS engine stricter about variable redeclaration
I believe the Pocket add-on will be discontinued. Adding Nate to see if we should just mark it as incompatible with Nightly right away.
Flags: needinfo?(nate)

Comment 3

3 years ago
It is getting phased out, but we can take a look to see if it's an easy/quick patch. Any sense of when the Nightly will go to full public release?

Thanks!
Flags: needinfo?(nate)
(Reporter)

Comment 4

3 years ago
(In reply to Nate Weiner from comment #3)
> It is getting phased out, but we can take a look to see if it's an
> easy/quick patch.

Thanks!

> Any sense of when the Nightly will go to full public
> release?

Nightly is currently at version 35. According to our Release Calendar[1] , that will get released to our Aurora (alpha) users on Oct 13, to Beta users on Nov 24, and it'll become a Firefox release in January 6 (2015).

(Also, for the record - there was a suggestion[2] on the newsgroup thread about this change that we relax the "no redeclarations" rule, which seems to be the proximal cause of bustage here.  I don't know if that suggestion will go anywhere, though.)

[1] https://wiki.mozilla.org/RapidRelease/Calendar
[2] https://groups.google.com/d/msg/mozilla.dev.platform/tezdW299Zds/w4YXqHmAgkEJ

Comment 5

3 years ago
The SocialAPI-based of pocket does not have the same functionality as the current pocket addon. 
Cant view the recent saved pages using api. It only works as save page.
The pocket addon is far more usefull than the api. I hope it does not get phased out.
(Reporter)

Comment 6

3 years ago
(In reply to Sunny from comment #5)
> The pocket addon is far more usefull than the api. I hope it does not get
> phased out.

I prefer the old extension as well (and value its functionality), but let's try to keep advocacy comments to a minimum.  Mozilla's Bugzilla instance is not the right place for discussion/debate on the merits of another organization's decisions.  (And I believe Pocket has already made the decision in this case -- though I'm hopeful that they might still fix one-off bugs like this one.)

This bug will be most likely to be fixed if it's easily-digestible & focused on the actual coding problem, if & when Pocket's devs get around to fixing it -- so let's do our best to leave it that way for them.
(In reply to Nate Weiner from comment #3)
> It is getting phased out, but we can take a look to see if it's an
> easy/quick patch. Any sense of when the Nightly will go to full public
> release?
> 

A mass find-and-replace for 'let' with 'var' fixed it for me.
The update shouldn't be too difficult. Any way I can help?
Flags: needinfo?(nate)
I made all of the changes I stated in the previous comment, and set up a github repo for it: https://github.com/valenting/pocket

It works properly in all versions of Firefox I tried.

Comment 9

3 years ago
(In reply to Valentin Gosu [:valentin] from comment #8)
> I made all of the changes I stated in the previous comment, and set up a
> github repo for it: https://github.com/valenting/pocket
> 
> It works properly in all versions of Firefox I tried.

Wow thanks this work perfectly now.
It seems that the addon just got updated!

http://getpocket.com/firefox/upgraded/?v=3.0.6&n=448&t=0&l=1
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Flags: needinfo?(nate)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.