Open Bug 1069134 Opened 5 years ago Updated 3 years ago

"Open Containing Folder" icon displayed in the Library even if the download has been moved to another folder

Categories

(Firefox :: Downloads Panel, defect)

defect
Not set

Tracking

()

People

(Reporter: rekha.n, Unassigned)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

Attachments

(1 obsolete file)

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:32.0) Gecko/20100101 Firefox/32.0
Build ID: 20140911151253

Steps to reproduce:

1. download an item through firefox of windows.
2. click on the downloads icon, and click on the icon 'open containing folder' nect to the item and the folder is now opened. Move the item to another folder.
3. Again click on the downloads icon, the icon will not be present next to the item.
But if you open show all downloads window, the icon will be present next to the item.


Actual results:

Open containing folder icon is present even if the item is moved from downloaded folder


Expected results:

Open containing folder icon should disappear if the item is moved from downloaded folder
Summary: downloads - issue in open containing folder → Downloads - issue in display of open containing folder icon
Component: Untriaged → Downloads Panel
Summary: Downloads - issue in display of open containing folder icon → "Open Containing Folder" icon displayed in the Library even if the download has been moved to another folder
Assignee: nobody → yfdyh000
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
OS: Windows 7 → All
Hardware: x86_64 → All
Attached patch patch (obsolete) — Splinter Review
Attachment #8491654 - Flags: review?(paolo.mozmail)
Also, please note bug 865208, that it is pointed out the should be disabled instead of hidden, but the not reflected in the current Firefox download panel.
See Also: → 865208
(In reply to YF (Yang) from comment #2)

> Also, please note bug 865208, that it is pointed out the should be disabled
> instead of hidden, but the not reflected in the current Firefox download
> panel.

Yang, I understood your point with bug 865208 - https://bugzilla.mozilla.org/show_bug.cgi?id=865208 
What does the requirement description suggested you to do? 
Please do the needful as it suggests and ignore this bug if this is not valid according to that.
People maybe want to a visible and disabled buttons to indicate that according to bug 865208, but maybe not. This requires ux to determine.

Maybe they do not need that if this bug been fixed. I think we can ignore it at the moment.
Duplicate of this bug: 865208
Blocks: 726451
Keywords: uiwanted
Comment on attachment 8491654 [details] [diff] [review]
patch

The main difficulty here is computing the "exists" attribute.

Unless there have been some changes of which I'm unaware, the attribute is not updated when the file is moved, so we may end up still displaying the icon, even if the file is absent.

Updating the attribute is difficult because we cannot do this for all items, for performance reasons. We must do it in the background, and only for the currently visible items. In theory, we also need to update the attribute even if the user did not interact with the window (with file system monitoring or polling), though it would be enough if we can just trigger a refresh on some interactions (like item selected or attempt to open folder).

So, this apparently simple bug is quite complex, and I'm not available to follow it thoroughly these days. You're of course welcome to continue working on it if you want, and I can provide reviews, but I'd recommend selecting something easier first.
Attachment #8491654 - Flags: review?(paolo.mozmail)
Attachment #8491654 - Attachment is obsolete: true
Assignee: yfdyh000 → nobody
Status: ASSIGNED → NEW
Version: 32 Branch → Trunk
As my first bug to start up with would u please assign me this bug.
see comment 6. Unless Paolo now has time to mentor this bug, it may be hard.
Flags: needinfo?(paolo.mozmail)
(In reply to Siddartha L K [:siddu] from comment #7)
> As my first bug to start up with would u please assign me this bug.

Thank you for signing up for helping out with Mozilla development! I believe this bug would be better handled after you gain some experience with simpler ones. You can find bugs we explicitly marked as "good first bugs" using this interface:

http://www.joshmatthews.net/bugsahoy/?simple=1
Flags: needinfo?(paolo.mozmail)
Hiding the icon and greying out the option in the context menu is a good option as it is what we already do in the downloads doorhanger. (Explaining why it is not possible with a grey icon and a changed tooltip might be helpful but more than necessary.)
Keywords: uiwanted
Depends on: 1380262
You need to log in before you can comment on or make changes to this bug.