106914 - unable to close Image Manager window due to javascript errors

Status: VERIFIED FIXED

(Core :: Networking: Cookies, defect)

Description

[Henrik Gemal]

If I open Image Manager I cant close it again by pressing the OK button:

Warning: reference to undefined property
ipermissions[deletedImagePermissions[iperm_count]]
Source File: chrome://communicator/content/wallet/CookieViewer.js
Line: 538

Error: ipermissions[deletedImagePermissions[iperm_count]] has no properties
Source File: chrome://communicator/content/wallet/CookieViewer.js
Line: 538

build 2001102503

Comment 1

[Stephen P. Morse]

*** This bug has been marked as a duplicate of 106866 ***

Comment 2

[Terri Preston]

Verified Duplicate

Comment 3

[Stephen P. Morse]

Wait a minute.  This can't be a dup of 106886 because that bug has to do with 
password manager and this one has to do with image manager.  The js error 
reported here is for image/cookie manager only (same code) and cannot possible 
occur when running password manager.

Comment 4

[Stephen P. Morse]

I am unable to reproduce.  Running with today's build on NT.  tever, can you 
reproduce this?

gemal, can you get to this error from a fresh profile?  If so, can you give a 
detailed description of exactly every step that you did to get to the error.

Comment 5

[Henrik Gemal]

i just reproduced this in 20011026:

1. right click on a image and say block images.
2. open image manager
3. delete the host you just added
4. click the Ok button and nuthing happens..

Comment 6

[Stephen P. Morse]

OK, I'm able to reproduce it.  But the conditions for being able to do so are 
not as simple as gemal described.  I believe it is related to having at least 
two entries on the block list and you are attempting to delete the second one.  
In any case, here is a foolproof procedure for reproducing.

1. Start with a fresh profile (assures there is nothing in block-image list
2. Go to http://www.mozilla.org
3. Point to the lizard and do tasks->privacy->images->block
4. Go to http://www.switchboard.com
5. Point to first image on page and do tasks->privacy->images->block
6. Go to image manager (tasks->privacy->images->view
7. Click on the "remove all" button
8. Press OK

Comment 7

[Stephen P. Morse]

Tracking this down was quite tedious because it appears to be caused by an 
obscure javascript bug.  See bug 107138 that I just filed on that bug.  However, 
now that I understand what is happening, I can easily put in some bulletproofing 
that works around the js bug.  Attaching patch.

Comment 8

[Stephen P. Morse]

Attachment: use parseInt to avoid the problem in bug 107138

Comment 9

[Stephen P. Morse]

cc'ing jag and alecf for reviews

Comment 10

[Stephen P. Morse]

The problem here is the same problem as in bug 106866 but in a different 
module.  The patches for each are similar.

Comment 11

[Thorsten Konetzko]

I dont know if I see a dupe of this bug here, but the problem is similar:
Clicking 'OK' in the image manager just does nothing though I don't see an error
message like described.

This is Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:0.9.5+) Gecko/20011026

Comment 12

[Stephen P. Morse]

I'm sure it's a dup.  Especially if you tried to do a delete that included the 
second item in the list.

Comment 13

[Thorsten Konetzko]

Deleting items is working, closing the manager (including save changes) does not.
This is not depending on whether I try to delete none, the second or any other item.

Is this reproducable at yours or do you need some more information?

Comment 14

[Stephen P. Morse]

*** Bug 107351 has been marked as a duplicate of this bug. ***

Comment 15

[Alec Flett]

Comment on attachment 55396 [details] [diff] [review]
use parseInt to avoid the problem in bug 107138

cool. This code will be faster too, because we don't have to keep accessing deletedCookies[cookieCount]

Comment 16

[jag (Peter Annema)]

Comment on attachment 55396 [details] [diff] [review]
use parseInt to avoid the problem in bug 107138

r=jag

Comment 17

[Stephen P. Morse]

fix checked in

Comment 18

[R.K.Aa.]

*** Bug 107747 has been marked as a duplicate of this bug. ***

Comment 19

[Henrik Gemal]

v 20020222