Closed
Bug 1069242
Opened 10 years ago
Closed 10 years ago
[Contacts] Missing test in bug 1062168
Categories
(Firefox OS Graveyard :: Gaia::Contacts, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.1 S5 (26sep)
People
(Reporter: hola, Assigned: hola)
Details
Attachments
(1 file)
Follow up bug to make an integration test to check that the problem described in bug 1062168 keeps being fixed in the future.
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → hola
|
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8491449 -
Flags: review?(jmcf)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8491449 [details] [review] Pull Request #24176 Redirecting review to Cristian as he is more familiar than me with integration tests
Attachment #8491449 -
Flags: review?(jmcf) → review?(crdlc)
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8491449 [details] [review] Pull Request #24176 Please take a look at some comments on github and also take care of step 6: "Write some substring (substring of some contact)". I couldn't see it in the integration test
Attachment #8491449 -
Flags: review?(crdlc)
|
|
Assignee | |
Comment 4•10 years ago
|
||
Comment on attachment 8491449 [details] [review] Pull Request #24176 I think everything you saw on the PR has been fixed. Also, I added the substring search as you suggested.
Attachment #8491449 -
Flags: review?(crdlc)
|
|
Assignee | |
Updated•10 years ago
|
Target Milestone: --- → 2.1 S5 (26sep)
|
|
||
Comment 5•10 years ago
|
||
Comment on attachment 8491449 [details] [review] Pull Request #24176 LGTM, thanks a lot
Attachment #8491449 -
Flags: review?(crdlc) → review+
|
|
||
Comment 6•10 years ago
|
||
Merged in master: https://github.com/mozilla-b2g/gaia/commit/a4a9c986af0a51db036d1198918dcc4f5f43042b
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•