Add a memory graph to the timeline

VERIFIED FIXED in Firefox 36

Status

P2
normal
VERIFIED FIXED
5 years ago
9 months ago

People

(Reporter: vporof, Assigned: vporof)

Tracking

unspecified
Firefox 36
Dependency tree / graph
Bug Flags:
in-testsuite +
qe-verify +

Firefox Tracking Flags

(firefox36 verified)

Details

Attachments

(1 attachment, 4 obsolete attachments)

Comment hidden (empty)
(Assignee)

Updated

5 years ago
Assignee: nobody → vporof
Status: NEW → ASSIGNED
(Assignee)

Updated

5 years ago
Priority: -- → P2
(Assignee)

Updated

5 years ago
Depends on: 1070089
(Assignee)

Updated

5 years ago
Blocks: 1066361
(Assignee)

Comment 1

5 years ago
Posted image screenshot (obsolete) —
Attachment #8498900 - Flags: ui-review?(paul)

Updated

5 years ago
Attachment #8498900 - Flags: ui-review?(paul) → ui-review+
(Assignee)

Comment 2

5 years ago
Posted patch wip 1 (obsolete) — Splinter Review
WIP. Needs a test.
(Assignee)

Comment 3

5 years ago
Posted patch timeline-memory.patch (obsolete) — Splinter Review
We can land this before 1070089.
Attachment #8499496 - Flags: review?(paul)
(Assignee)

Updated

5 years ago
Attachment #8499462 - Attachment is obsolete: true
(Assignee)

Comment 4

5 years ago
Comment on attachment 8499496 [details] [diff] [review]
timeline-memory.patch

Needs a checkbox
Attachment #8499496 - Flags: review?(paul)
(Assignee)

Updated

5 years ago
Depends on: 1077438
(Assignee)

Comment 5

5 years ago
Posted patch v2Splinter Review
Attachment #8498900 - Attachment is obsolete: true
Attachment #8499496 - Attachment is obsolete: true
Attachment #8508023 - Flags: review?(paul)
(Assignee)

Comment 6

5 years ago
^ Rebased on top of bug 1070089.
Still trying to figure out what's going on, but I get:

> this._paintBatches.get is undefined

… when debugging a B2G app.

Might be my fault (could be a rebase issue).
(It was a rebase issue).
Comment on attachment 8508023 [details] [diff] [review]
v2

Review of attachment 8508023 [details] [diff] [review]:
-----------------------------------------------------------------

Well… I don't even have nits.

Tested with tabs, Firefox OS and WebIDE on Firefox main process.
Attachment #8508023 - Flags: review?(paul) → review+
Posted patch rebased patch (obsolete) — Splinter Review
(rebased patch. might help)
(Assignee)

Comment 11

4 years ago
Thanks!
(Assignee)

Comment 12

4 years ago
Comment on attachment 8516642 [details] [diff] [review]
rebased patch

v2 applies cleanly on fx-team tip.
Attachment #8516642 - Attachment is obsolete: true
(Assignee)

Updated

4 years ago
Whiteboard: [fixed-in-fx-team]
(Assignee)

Comment 16

4 years ago
Let's try this again: https://hg.mozilla.org/integration/fx-team/rev/942aec7a1572
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/5e58c0e59964
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 36
Victor, do we have an acceptance criteria for this patch? Anything manual QA can look at here?
Flags: needinfo?(vporof)
(Assignee)

Comment 20

4 years ago
(In reply to Andrei Vaida, QA [:avaida] from comment #19)
> Victor, do we have an acceptance criteria for this patch? Anything manual QA
> can look at here?

Yes. Open the timeline and see if the memory graph works :)
Flags: needinfo?(vporof)
No issues found while performing Exploratory testing on this feature, using Nightly 36.0a1 (2014-11-16). In terms of cross-platform compatibility, tests covered Windows 7 64-bit, Mac OS X 10.9.5 and Ubuntu 12.04 LTS 32-bit.
Status: RESOLVED → VERIFIED
status-firefox36: --- → verified
Flags: qe-verify+
QA Contact: andrei.vaida
Sorry for the spam. Moving bugs to Firefox :: Developer Tools: Performance Tools (Profiler/Timeline).

dkl
Component: Developer Tools: Timeline → Developer Tools: Performance Tools (Profiler/Timeline)

Updated

9 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.