Closed Bug 1069421 Opened 11 years ago Closed 11 years ago

Add a memory graph to the timeline

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect, P2)

Product:
DevTools
Component:
Performance Tools (Profiler/Timeline)
Type:
defect

Tracking

(firefox36 verified)

Status:
VERIFIED FIXED
Milestone:
Firefox 36
Tracking Flags:
Tracking Status
firefox36 --- verified

People

(Reporter: vporof, Assigned: vporof)

References

Details

Attachments

(1 file, 4 obsolete files)

v2
94.22 KB, patch
paul
: review+
Details | Diff | Splinter Review
No description provided.
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Priority: -- → P2
Depends on: 1070089
Blocks: 1066361
Attached image screenshot (obsolete) —
Attachment #8498900 - Flags: ui-review?(paul)
Attachment #8498900 - Flags: ui-review?(paul) → ui-review+
Attached patch wip 1 (obsolete) — — Splinter Review
WIP. Needs a test.
Attached patch timeline-memory.patch (obsolete) — — Splinter Review
We can land this before 1070089.
Attachment #8499496 - Flags: review?(paul)
Attachment #8499462 - Attachment is obsolete: true
Comment on attachment 8499496 [details] [diff] [review] timeline-memory.patch Needs a checkbox
Attachment #8499496 - Flags: review?(paul)
Depends on: 1077438
Attached patch v2 — — Splinter Review
Attachment #8498900 - Attachment is obsolete: true
Attachment #8499496 - Attachment is obsolete: true
Attachment #8508023 - Flags: review?(paul)
^ Rebased on top of bug 1070089.
Still trying to figure out what's going on, but I get: > this._paintBatches.get is undefined … when debugging a B2G app. Might be my fault (could be a rebase issue).
(It was a rebase issue).
Comment on attachment 8508023 [details] [diff] [review] v2 Review of attachment 8508023 [details] [diff] [review]: ----------------------------------------------------------------- Well… I don't even have nits. Tested with tabs, Firefox OS and WebIDE on Firefox main process.
Attachment #8508023 - Flags: review?(paul) → review+
Attached patch rebased patch (obsolete) — — Splinter Review
(rebased patch. might help)
Thanks!
Comment on attachment 8516642 [details] [diff] [review] rebased patch v2 applies cleanly on fx-team tip.
Attachment #8516642 - Attachment is obsolete: true
Whiteboard: [fixed-in-fx-team]
Let's try this again: https://hg.mozilla.org/integration/fx-team/rev/942aec7a1572
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/5e58c0e59964
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 36
Victor, do we have an acceptance criteria for this patch? Anything manual QA can look at here?
Flags: needinfo?(vporof)
(In reply to Andrei Vaida, QA [:avaida] from comment #19) > Victor, do we have an acceptance criteria for this patch? Anything manual QA > can look at here? Yes. Open the timeline and see if the memory graph works :)
Flags: needinfo?(vporof)
No issues found while performing Exploratory testing on this feature, using Nightly 36.0a1 (2014-11-16). In terms of cross-platform compatibility, tests covered Windows 7 64-bit, Mac OS X 10.9.5 and Ubuntu 12.04 LTS 32-bit.
Status: RESOLVED → VERIFIED
status-firefox36: --- → verified
Flags: qe-verify+
QA Contact: andrei.vaida
Sorry for the spam. Moving bugs to Firefox :: Developer Tools: Performance Tools (Profiler/Timeline). dkl
Component: Developer Tools: Timeline → Developer Tools: Performance Tools (Profiler/Timeline)
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: